Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug OCPBUGS-6778: Correct condition for rejecting connection #27876

Merged
merged 1 commit into from Aug 8, 2023

Conversation

gryf
Copy link
Member

@gryf gryf commented Apr 14, 2023

Test 'Pods cannot access the /config/master API endpoint fails' assumes, that curl output should contain Connection refused, which is not always true, when cluster would be deployed on OpenStack with different CNI (like Kuryr), which is using Security Groups to block the traffic to the internal API. In that case rules created by SG would drop the packet, so there will be no response rather then refuse.

This patch is correcting the test case, where there is added additional response string and added timeout option for curl, just to save the time.

Test 'Pods cannot access the /config/master API endpoint fails' assumes,
that curl output should contain Connection refused, which is not always
true, when cluster would be deployed on OpenStack with different CNI
(like Kuryr), which is using Security Groups to block the traffic to the
internal API. In that case rules created by SG would drop the packet,
so there will be no response rather then refuse.

This patch is correcting the test case, where there is added additional
response string and added timeout option for curl, just to save the
time.
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik April 14, 2023 09:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@gryf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-etcd-scaling 33ce5ec link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-csi 33ce5ec link false /test e2e-gcp-csi
ci/prow/e2e-openstack-ovn 33ce5ec link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-etcd-scaling 33ce5ec link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-agnostic-ovn-cmd 33ce5ec link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-csi 33ce5ec link false /test e2e-aws-csi
ci/prow/e2e-azure-ovn-etcd-scaling 33ce5ec link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-single-node-serial 33ce5ec link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 33ce5ec link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gryf
Copy link
Member Author

gryf commented Apr 17, 2023

/test e2e-aws-ovn-serial

@MaysaMacedo
Copy link
Contributor

/retitle Bug OCPBUGS-6778: Correct condition for rejecting connection

@openshift-ci openshift-ci bot changed the title [OCPBUGS-6778] Correct condition for rejecting connection. Bug OCPBUGS-6778: Correct condition for rejecting connection Apr 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 20, 2023
@openshift-ci-robot
Copy link

@gryf: This pull request references Jira Issue OCPBUGS-6778, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Test 'Pods cannot access the /config/master API endpoint fails' assumes, that curl output should contain Connection refused, which is not always true, when cluster would be deployed on OpenStack with different CNI (like Kuryr), which is using Security Groups to block the traffic to the internal API. In that case rules created by SG would drop the packet, so there will be no response rather then refuse.

This patch is correcting the test case, where there is added additional response string and added timeout option for curl, just to save the time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor

/jira refresh

1 similar comment
@gryf
Copy link
Member Author

gryf commented Apr 21, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 21, 2023
@openshift-ci-robot
Copy link

@gryf: This pull request references Jira Issue OCPBUGS-6778, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 21, 2023
@gryf
Copy link
Member Author

gryf commented Apr 21, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@gryf: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gryf
Copy link
Member Author

gryf commented May 10, 2023

Hello @deads2k and @mfojtik! is there anything else I need to do regarding this patch to be merged?

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit a4bbe97 into openshift:master Aug 8, 2023
17 of 26 checks passed
@openshift-ci-robot
Copy link

@gryf: Jira Issue OCPBUGS-6778: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6778 has been moved to the MODIFIED state.

In response to this:

Test 'Pods cannot access the /config/master API endpoint fails' assumes, that curl output should contain Connection refused, which is not always true, when cluster would be deployed on OpenStack with different CNI (like Kuryr), which is using Security Groups to block the traffic to the internal API. In that case rules created by SG would drop the packet, so there will be no response rather then refuse.

This patch is correcting the test case, where there is added additional response string and added timeout option for curl, just to save the time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gryf: new pull request created: #28151

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants