New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug OCPBUGS-6778: Correct condition for rejecting connection #27876
Bug OCPBUGS-6778: Correct condition for rejecting connection #27876
Conversation
Test 'Pods cannot access the /config/master API endpoint fails' assumes, that curl output should contain Connection refused, which is not always true, when cluster would be deployed on OpenStack with different CNI (like Kuryr), which is using Security Groups to block the traffic to the internal API. In that case rules created by SG would drop the packet, so there will be no response rather then refuse. This patch is correcting the test case, where there is added additional response string and added timeout option for curl, just to save the time.
@gryf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws-ovn-serial |
/retitle Bug OCPBUGS-6778: Correct condition for rejecting connection |
@gryf: This pull request references Jira Issue OCPBUGS-6778, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
1 similar comment
/jira refresh |
@gryf: This pull request references Jira Issue OCPBUGS-6778, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@gryf: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest-required
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gryf, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a4bbe97
into
openshift:master
@gryf: Jira Issue OCPBUGS-6778: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-6778 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gryf: new pull request created: #28151 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Test 'Pods cannot access the /config/master API endpoint fails' assumes, that curl output should contain Connection refused, which is not always true, when cluster would be deployed on OpenStack with different CNI (like Kuryr), which is using Security Groups to block the traffic to the internal API. In that case rules created by SG would drop the packet, so there will be no response rather then refuse.
This patch is correcting the test case, where there is added additional response string and added timeout option for curl, just to save the time.