Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13158: Run new tests which monitors in-cluster API server disruption as daemonsets on masters/workers #27909

Merged
merged 17 commits into from Jul 20, 2023
Merged

OCPBUGS-13158: Run new tests which monitors in-cluster API server disruption as daemonsets on masters/workers #27909

merged 17 commits into from Jul 20, 2023

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented May 5, 2023 •
edited

Add run-disruption command to collect only API server disruptions. This is meant to run on server side, so that we could check API server connectivity via service network / internal LB / localhost.
pkg/monitor was updated to start it on cluster, run it as daemonset on every node, fetch intervals as daemonsets and mix them in main timeline

TODO:

  • Fix merging in-cluster-events.json in existing Intervals
  • Along with the source node name add custom label - disruption/internal-lb node=ip-.... and disruption/service-network name=ip-...
  • Run monitors on masters to monitor API via localhost - to find out what is the effect of CNI update
    • seems there is no kubeconfig with certificates to use? hostNetwork: true + lb.kubeconfig solves it
  • Run late test after upgrade is complete
  • Tests with observers fail to start, as in-cluster monitor is started twice
  • Sometimes the container fails to start and prints '...PaxHeader....'
    • that looks like a tar result, seems its confined to cgroupsv2 tests

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs
Copy link
Member Author

vrutkovs commented May 5, 2023

/test e2e-gcp-ovn-upgrade

@vrutkovs
Copy link
Member Author

vrutkovs commented May 5, 2023

/test e2e-gcp-ovn-upgrade

@vrutkovs vrutkovs changed the title Create a new tests which monitors in-cluster API server disruption OCPBUGS-13158: Create a new tests which monitors in-cluster API server disruption May 5, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 5, 2023
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-13158, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 May 5, 2023 12:51
@vrutkovs vrutkovs changed the title OCPBUGS-13158: Create a new tests which monitors in-cluster API server disruption OCPBUGS-13158: Run new tests which monitors in-cluster API server disruption as daemonsets on masters/workers May 5, 2023
@vrutkovs vrutkovs marked this pull request as ready for review May 5, 2023 12:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2023
@vrutkovs
Copy link
Member Author

vrutkovs commented May 5, 2023

/cc @tkashem

@openshift-ci openshift-ci bot requested a review from tkashem May 5, 2023 12:52
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-13158, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add --api-disruption-only option to run-monitor command to collect only API server disruptions.
Add early/late tests to run monitor checking apiserver disruption via api-int / service network.

Currently the result is not being included in the spyglass, we'll need either:

  • gather-extra update to fetch e2e json from nodes and include it in tests results
  • update late tests to do this automatically (if possible)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jcantrill and jwforres May 5, 2023 12:54
@vrutkovs
Copy link
Member Author

vrutkovs commented May 9, 2023

/retest-required

@vrutkovs vrutkovs changed the title OCPBUGS-13158: Run new tests which monitors in-cluster API server disruption as daemonsets on masters/workers WIP OCPBUGS-13158: Run new tests which monitors in-cluster API server disruption as daemonsets on masters/workers May 15, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2023
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-13158, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add --api-disruption-only option to run-monitor command to collect only API server disruptions.
Add early/late tests to run monitor checking apiserver disruption via api-int / service network.

pkg/monitor was updated to iterate nodes, fetch events and mix them in main timeline

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs force-pushed the in-cluster-disruption branch 2 times, most recently from ea990ec to 8574550 Compare May 15, 2023 17:10
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs vrutkovs force-pushed the in-cluster-disruption branch 3 times, most recently from 72639ec to 1075a01 Compare May 16, 2023 16:04
@vrutkovs
monitor: use monitor.EventDir to store events
db923e7
@vrutkovs
disruption: make factory return Sampler interface
e24202c
@vrutkovs
disruption: create RemoteSampler
e35fc9d
@vrutkovs
monitor: stop remote sampler before uploading intervals
3458edb
@vrutkovs
in-cluster disruption: rework to use go:embed
23f6a6f 
Update other manifests to set generated namespace name
@vrutkovs
Use nodedetails to fetch files from the node
401c94d
@vrutkovs
in-cluster monitor: output to stdout
bbf9f9f 
Previously these functions were called from the test, but now framework.Logf won't produce any output
@vrutkovs
in-cluster monitor: add sigint/segterm handlers
ddd7c60
@vrutkovs
in-cluster monitor: use cluster reader with custom role to list oauth…
29d15f0 
…clients
@vrutkovs
in-cluster monitor: run two daemonsets, as internal LB needs to be ac…
e184f6a 
…cessed via hostnetwork
@vrutkovs
in-cluster monitor: use custom role instead of cluster-reader
f27b746
@vrutkovs
in-cluster monitor: remove daemonsets before entire namespace to prev…
8c86918 
…ent trailing disruption intervals
@vrutkovs
in-cluster monitoring: use new disruption backend only
de89e21
@vrutkovs
in-cluster disruption: check apiservers via localhost kubeconfig
50a6cd9
@vrutkovs
in-cluster monitors: run monitor teardown on SIGINT
f5dd947 
Either of signal  handlers - in ginkgo tests or run-monitor - should first attempt to stop in-cluster monitors before proceeding to have data saved on disk and processed
@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d86a51 and 2 for PR HEAD f5dd947 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0bb2d20 and 1 for PR HEAD f5dd947 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023 •
edited

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade f5dd947 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial f5dd947 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-rt-upgrade f5dd947 link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 40dc6df and 0 for PR HEAD f5dd947 in total

@openshift-merge-robot openshift-merge-robot merged commit dd46b80 into openshift:master Jul 20, 2023
20 of 23 checks passed
@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-13158: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13158 has been moved to the MODIFIED state.

In response to this:

Add run-disruption command to collect only API server disruptions. This is meant to run on server side, so that we could check API server connectivity via service network / internal LB / localhost.
pkg/monitor was updated to start it on cluster, run it as daemonset on every node, fetch intervals as daemonsets and mix them in main timeline

TODO:

  • Fix merging in-cluster-events.json in existing Intervals
  • Along with the source node name add custom label - disruption/internal-lb node=ip-.... and disruption/service-network name=ip-...
  • Run monitors on masters to monitor API via localhost - to find out what is the effect of CNI update
  • seems there is no kubeconfig with certificates to use? hostNetwork: true + lb.kubeconfig solves it
  • Run late test after upgrade is complete
  • Tests with observers fail to start, as in-cluster monitor is started twice
  • Sometimes the container fails to start and prints '...PaxHeader....'
    • that looks like a tar result, seems its confined to cgroupsv2 tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor

@vrutkovs something seems wrong, your latest presubmits don't seem to have any internal-lb or localhost backends being reported: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/27909/pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade/1680146387003510784/artifacts/e2e-aws-ovn-upgrade/openshift-e2e-test/artifacts/junit/backend-disruption_20230715-101030.json

Nor do I see any results in our database since this went live, did a late change break collection of the data from the nodes?

@vrutkovs
Copy link
Member Author

First upgrade tests won't have this - the test needs to be present in version, as disruption monitor is started when cluster is being installed. We need to wait for a few versions for it to soak in

@vrutkovs vrutkovs mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin dgoodwin left review comments

@tkashem tkashem tkashem left review comments

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@wangke19 wangke19 Awaiting requested review from wangke19

@jwforres jwforres Awaiting requested review from jwforres

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@vrutkovs @openshift-ci-robot @stbenjam @dgoodwin @dinhxuanvu @tkashem @deads2k @openshift-merge-robot