Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] CCO-367: Allow CCO to be Upgradeable=False when credentialsMode=Manual #27941

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #27895

/assign suhanime

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 24, 2023

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug CCO-367 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_12318341":"Operation value must be a string"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #27895

/assign suhanime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik May 24, 2023 19:23
@suhanime
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 24, 2023

@suhanime: This pull request references CCO-367 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suhanime
Copy link

/retest

1 similar comment
@suhanime
Copy link

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade c54f167 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suhanime
Copy link

@deads2k @mfojtik Would appreciate your eyes on this PR.
While e2es were running for CCO-367, we discovered that we needed to backport this change all the way to 4.10.
I believe the changes shouldn't affect the e2e-aws-ovn-single-node-upgrade, and fwiw, I think that e2e hasn't succeeded since early February this year.

@abutcher
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@abutcher
Copy link
Member

@sdodson Can you please review for the STS periodic?

@sdodson
Copy link
Member

sdodson commented May 31, 2023

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 31, 2023
@sdodson sdodson added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 40594c5 into openshift:release-4.12 May 31, 2023
21 of 22 checks passed
@suhanime
Copy link

suhanime commented Jun 1, 2023

/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link
Author

@suhanime: new pull request created: #27961

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet