Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip operator framework from resource watch and fix bugs #27972

Merged
merged 3 commits into from Jun 22, 2023
Merged

strip operator framework from resource watch and fix bugs #27972

merged 3 commits into from Jun 22, 2023

Conversation

xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Jun 7, 2023 •
edited

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Jun 7, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2023
@openshift-ci openshift-ci bot requested review from mfojtik and spadgett June 7, 2023 21:17
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 86c9bfc

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd Medium

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Jun 8, 2023

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@xueqzhan: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5960bb20-059d-11ee-9a5f-3eb7dcbebe88-0

@xueqzhan xueqzhan changed the title Add debug log for resource watch strip operator framework from resource watch and fix bugs Jun 14, 2023
@xueqzhan
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

@xueqzhan: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a8ce0460-0abb-11ee-8e89-42030f6aceed-0

@xueqzhan
Copy link
Contributor Author

/hold

Need to change release repo first

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 9438791

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn High
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node High

@xueqzhan
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

@xueqzhan: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ee9eee20-0adc-11ee-94bb-24f31684fc2e-0

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 14, 2023
@xueqzhan
Copy link
Contributor Author

/unhold as this is backward compatible now.

@xueqzhan
Copy link
Contributor Author

/retest-required

deads2k
deads2k reviewed Jun 20, 2023
View reviewed changes
pkg/monitor/resourcewatch/cmd/resourcewatch.go
},
}
var dummy string
cmd.Flags().StringVar(&dummy, "kubeconfig", "", "This option is not used any more. It will be removed in later releases")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should wire this back at some point, but no rush.

deads2k
deads2k reviewed Jun 20, 2023
View reviewed changes
pkg/monitor/resourcewatch/storage/git_store.go
@@ -31,19 +31,19 @@ type workingSet struct {

func (s *workingSet) isWorkingOn(key string) bool {
s.lock.RLock()
defer s.lock.RLock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

@deads2k
Copy link
Contributor

deads2k commented Jun 20, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@xueqzhan
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023
@xueqzhan
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD aaa35d9 and 2 for PR HEAD 71da72d in total

@xueqzhan
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023 •
edited

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 71da72d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-upgrade 71da72d link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 71da72d link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-csi 71da72d link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d1a963f and 1 for PR HEAD 71da72d in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 71da72d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High

@openshift-merge-robot openshift-merge-robot merged commit df2acd5 into openshift:master Jun 22, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xueqzhan @openshift-trt-bot @deads2k @openshift-ci-robot @openshift-merge-robot