Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake ci-cluster-network-liveness and new backend disruption failures to avoid payload rejections #27990

Merged
merged 1 commit into from Jun 24, 2023

Conversation

DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Jun 21, 2023

TRT-1095

We'll flake these backends to avoid failing payloads.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@DennisPeriquet DennisPeriquet marked this pull request as ready for review June 21, 2023 18:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@openshift-ci openshift-ci bot requested review from bparees and csrwng June 21, 2023 18:43
@DennisPeriquet DennisPeriquet changed the title Flake ci-cluster-network-liveness disruption failures to avoid payload rejections Flake ci-cluster-network-liveness and new backend disruption failures to avoid payload rejections Jun 21, 2023
@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@dgoodwin
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD df2acd5 and 2 for PR HEAD e244a5b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7c47288 and 1 for PR HEAD e244a5b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@DennisPeriquet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade e244a5b link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node e244a5b link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade e244a5b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn e244a5b link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial e244a5b link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xueqzhan
Copy link
Contributor

/retest-required

func isExcludedDisruptionBackend(name string) bool {
excludedNames := []string{
"ci-cluster-network-liveness",
"kube-api-http1-external-lb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this excluded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new backend, anything mentioning http is, the originals were left alone and are running along side these.

@openshift-merge-robot openshift-merge-robot merged commit 24350d6 into openshift:master Jun 24, 2023
17 of 22 checks passed
@DennisPeriquet DennisPeriquet deleted the trt-1095 branch June 26, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants