Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13379: machines: add a test which verifies number of node reboots #27993

Merged
merged 2 commits into from Jun 23, 2023
Merged

OCPBUGS-13379: machines: add a test which verifies number of node reboots #27993

merged 2 commits into from Jun 23, 2023

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 22, 2023

Evolution of #27899 that uses the upstream helpers for waiting, generates a namespace as "normal", marks as allowed for privileged namespace, uses admin creds to pass SCC checks, uses upstream helpers to get logs, avoids recursion for looping, reports all failures for attempts, and reduces length.

/assign @vrutkovs

vrutkovs and others added 2 commits June 22, 2023 18:23
@vrutkovs
machines: add a test which verifies number of node reboots
b79135c 
This adds a new test which checks `journalctl --list-boots` to ensure no unexpected reboots occurred on the nodes. It would run on SNO clusters only

Its similar to `should report ready nodes the entire duration of the test run` except that its applicable to SNO - when the only node reboots it won't be recorded as a change in prometheus metric.
@deads2k
adjust the reboot test for brevity and clarity
0fffacc
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2023
@openshift-ci-robot
Copy link

@deads2k: This pull request references Jira Issue OCPBUGS-13379, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Evolution of #27899 that uses the upstream helpers for waiting, generates a namespace as "normal", marks as allowed for privileged namespace, uses admin creds to pass SCC checks, uses upstream helpers to get logs, avoids recursion for looping, reports all failures for attempts, and reduces length.

/assign @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 22, 2023
@deads2k deads2k mentioned this pull request Jun 22, 2023
Closed
2 tasks
@openshift-ci openshift-ci bot requested review from dmage and mfojtik June 22, 2023 19:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Jun 22, 2023

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

@deads2k: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k mentioned this pull request Jun 22, 2023
Merged
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0fffacc

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 High
pull-ci-openshift-origin-master-e2e-gcp-ovn High
pull-ci-openshift-origin-master-e2e-gcp-csi High
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Medium

@vrutkovs
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD df2acd5 and 2 for PR HEAD 0fffacc in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 0fffacc link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-rt-upgrade 0fffacc link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 0fffacc link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 0fffacc link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 0fffacc link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-csi 0fffacc link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-upgrade 0fffacc link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7c47288 into openshift:master Jun 23, 2023
16 of 23 checks passed
@openshift-ci-robot
Copy link

@deads2k: Jira Issue OCPBUGS-13379: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13379 has been moved to the MODIFIED state.

In response to this:

Evolution of #27899 that uses the upstream helpers for waiting, generates a namespace as "normal", marks as allowed for privileged namespace, uses admin creds to pass SCC checks, uses upstream helpers to get logs, avoids recursion for looping, reports all failures for attempts, and reduces length.

/assign @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member

/cherrypick release-4.13

@openshift-cherrypick-robot
Copy link

@vrutkovs: #27993 failed to apply on top of branch "release-4.13":

Applying: machines: add a test which verifies number of node reboots
Using index info to reconstruct a base tree...
M	test/extended/util/annotate/generated/zz_generated.annotations.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/generated/zz_generated.annotations.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 machines: add a test which verifies number of node reboots
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deads2k @openshift-ci-robot @openshift-trt-bot @vrutkovs @openshift-cherrypick-robot @openshift-merge-robot