USHIFT-647: skip sig-cli explain for CRDs in MicroShift #27996
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@chiragkyal: This pull request references USHIFT-647 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
test/extended/cli/explain.go
Outdated
| @@ -579,6 +602,9 @@ var _ = g.Describe("[sig-cli] oc explain", func() { | |||
| if *controlPlaneTopology == configv1.ExternalTopologyMode { | |||
| crdTypesTest = baseCRDTypes | |||
| } | |||
| if !doesCRDTypesExist(oc, crdTypesTest) { | |||
There was a problem hiding this comment.
Instead of skipping the test entirely, let's look for MicroShift and set crdTypesTest to the list we expect to see so we can test that explain works with them.
chiragkyal
force-pushed
the
USHIFT-647-crd
branch
from
9be95cf
to
aaa6765
Compare
|
cc @soltysh |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@chiragkyal: This pull request references USHIFT-647 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chiragkyal are those test failures known issues for this repo? @soltysh we discussed the approach Chirag is taking in this PR on slack. /assign @soltysh |
|
I do see some of them are failing in other PRs, also. /retest |
|
@chiragkyal: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chiragkyal, dhellmann, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit d4faa3d
into
openshift:master
This change will check if a cluster is MicroShift and make changes accordingly for
[sig-cli] oc explain should contain proper spec+status for CRDstest.