Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trt-1117: Test for update lease errors #28020

Merged

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Jul 2, 2023

Looks for matches indicating 'Failed to update lease' in journal logs.
Creates a new flake test case. We see update lease failures early on during the install so a grace period of 30 minutes is added from the first event time.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2023

@neisw: This pull request references trt-1117 which is a valid jira issue.

In response to this:

Looks for matches indicating 'Failed to update lease' in journal logs.
Creates a new flake test case. We see update lease failures early on during the install so a grace period of 30 minutes is added from the first event time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from csrwng and spadgett July 2, 2023 21:22
@neisw
Copy link
Contributor Author

neisw commented Jul 2, 2023

/payload-aggregate periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2023

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d54eb10-191e-11ee-80f0-5ac2cac2cc78-0

@xueqzhan
Copy link
Contributor

xueqzhan commented Jul 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@neisw
Copy link
Contributor Author

neisw commented Jul 3, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade b820bee link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn b820bee link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial b820bee link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-upgrade b820bee link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Comment on lines +525 to +528
var failedLeaseUpdateErrorRegex = regexp.MustCompile(`failed to update lease, error: Put \"(?P<URL>[a-z0-9.-:\/\-\?\=]+)\": (?P<MSG>[^\"]+)`)

// upper 'F'ailed and 'err'
var failedLeaseUpdateErrRegex = regexp.MustCompile(`Failed to update lease\" err\=\"Put \\\"(?P<URL>[a-z0-9.-:\/\-\?\=]+)\\\": (?P<MSG>[^\"]+)`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just [Ff]ailed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see they're different in other places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The err vs. error string is a bit different as well but if you see a common regex for them both that would work for me as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's fine, 2 simpler regex is better than 1 unreadable one.

@stbenjam
Copy link
Member

stbenjam commented Jul 3, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@openshift-trt-bot
Copy link

@openshift-merge-robot openshift-merge-robot merged commit acd302f into openshift:master Jul 4, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants