Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15893: Update permission to incl. watch for helmchartrepositories for console users #28044

Merged
merged 1 commit into from Jul 14, 2023
Merged

OCPBUGS-15893: Update permission to incl. watch for helmchartrepositories for console users #28044

merged 1 commit into from Jul 14, 2023

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Jul 11, 2023 •
edited

See also openshift/console-operator#775

Change the permission check for helmchartrepositories from get, list to get, list, watch.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 11, 2023
@openshift-ci-robot
Copy link

@jerolimov: This pull request references Jira Issue OCPBUGS-15893, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

See also openshift/console-operator#775

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@jerolimov: This pull request references Jira Issue OCPBUGS-15893, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

See also openshift/console-operator#775

Change the permission check for helmchartrepositories from get, list to get, list, watch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/assign @stlaz

@jerolimov
Copy link
Member Author

/retest

@jerolimov
Copy link
Member Author

/assign @bparees @deads2k

Hey, since @stlaz is on PTO, can you check this PR? Thanks

jhadvig
jhadvig approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparees
Copy link
Contributor

bparees commented Jul 12, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@jerolimov
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 158f668 and 2 for PR HEAD 5f7d4e5 in total

@jerolimov
Copy link
Member Author

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

@jerolimov
Copy link
Member Author

/test e2e-gcp-ovn-upgrade
/test e2e-gcp-ovn-upgrade
/test e2e-aws-ovn-single-node

@jerolimov
Copy link
Member Author

/test e2e-gcp-ovn

@openshift-merge-robot openshift-merge-robot merged commit 7b7684f into openshift:master Jul 14, 2023
19 of 22 checks passed
@openshift-ci-robot
Copy link

@jerolimov: Jira Issue OCPBUGS-15893: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-15893 has not been moved to the MODIFIED state.

In response to this:

See also openshift/console-operator#775

Change the permission check for helmchartrepositories from get, list to get, list, watch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

@jerolimov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 5f7d4e5 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node 5f7d4e5 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jerolimov
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 14, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jerolimov: new pull request created: #28054

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov deleted the OCPBUGS-15893 branch July 14, 2023 19:51
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@yapei yapei Awaiting requested review from yapei

@ibihim ibihim Awaiting requested review from ibihim

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@stlaz stlaz

@bparees bparees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jerolimov @openshift-ci-robot @bparees @openshift-cherrypick-robot @jhadvig @stlaz @deads2k @openshift-merge-robot