Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7333: Add consolesamples to the list of console resources that all users should have read access #28045

Merged
merged 1 commit into from Jul 14, 2023
Merged

ODC-7333: Add consolesamples to the list of console resources that all users should have read access #28045

merged 1 commit into from Jul 14, 2023

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Jul 11, 2023 •
edited

See also openshift/console-operator#776

Add new consolesamples resource to the list of resources that every (console) user could read (get, list, watch).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci bot

@jerolimov: This pull request references ODC-7333 which is a valid jira issue.

In response to this:

Follow up on openshift/console-operator#776

Add new consolesamples resource to the list of resources that every (console) user could read (get, list, watch).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@openshift-ci openshift-ci bot requested review from ibihim and s-urbaniak July 11, 2023 13:38
@jerolimov jerolimov changed the title [WIP] ODC-7333: Add consolesamples to the list of console resources that all users should have read access ODC-7333: Add consolesamples to the list of console resources that all users should have read access Jul 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci bot

@jerolimov: This pull request references ODC-7333 which is a valid jira issue.

In response to this:

See also openshift/console-operator#776

Add new consolesamples resource to the list of resources that every (console) user could read (get, list, watch).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@jerolimov
Copy link
Member Author

/assign @stlaz

@jerolimov
Copy link
Member Author

/retest

1 similar comment
@invincibleJai
Copy link
Member

/retest

@jerolimov
Copy link
Member Author

jerolimov commented Jul 12, 2023 •
edited

/assign @bparees @deads2k

Hey, since @stlaz is on PTO, can you check this PR? Thanks

jhadvig
jhadvig approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparees
Copy link
Contributor

bparees commented Jul 12, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 158f668 and 2 for PR HEAD e6c46f9 in total

@jerolimov
Copy link
Member Author

/retest-required

@invincibleJai
Copy link
Member

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a02345e and 1 for PR HEAD e6c46f9 in total

@jerolimov
Copy link
Member Author

/retest

@jerolimov
Copy link
Member Author

/retest-required

1 similar comment
@jerolimov
Copy link
Member Author

/retest-required

@jerolimov
Copy link
Member Author

/test e2e-gcp-ovn

1 similar comment
@jerolimov
Copy link
Member Author

/test e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

@jerolimov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial e6c46f9 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8cfd84e into openshift:master Jul 14, 2023
21 of 22 checks passed
@jerolimov jerolimov deleted the ODC-7333 branch July 14, 2023 18:09
@jerolimov jerolimov mentioned this pull request Jul 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@ibihim ibihim Awaiting requested review from ibihim

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@stlaz stlaz

@bparees bparees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jerolimov @openshift-ci-robot @invincibleJai @bparees @jhadvig @stlaz @deads2k @openshift-merge-robot