USHIFT-1463: add [apigroup] annotation to skip tests for MicroShift

[chiragkyal]

add [apigroup:operator.openshift.io] and [apigroup:oauth.openshift.io] annotations to skip tests for MicroShift
USHIFT-1463

[chiragkyal]

/retest

[openshift-ci-robot]

@chiragkyal: This pull request references USHIFT-1463 which is a valid jira issue.

In response to this:

add [apigroup] annotation to skip tests for MicroShift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@chiragkyal: This pull request references USHIFT-1463 which is a valid jira issue.

In response to this:

add [apigroup] annotation to skip tests for MicroShift
USHIFT-1463

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@chiragkyal: This pull request references USHIFT-1463 which is a valid jira issue.

In response to this:

add [apigroup:operator.openshift.io] and [apigroup:oauth.openshift.io] annotations to skip tests for MicroShift
USHIFT-1463

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ingvagabund]

@chiragkyal to make the review easier and faster would you please provide a location or a reason for why these additional groups are needed? It can be either a client invocation, need for an endpoint that is exposed only when e.g. oauth server is running, etc. Some of the dependencies can be hidden pretty deep.

[chiragkyal]

@ingvagabund I will try to elaborate on my understanding and reasoning for this change.

• multinetpolicy.go

  "[sig-network][Feature:MultiNetworkPolicy][Serial] should enforce a network policies on secondary network IPv6 [Suite:openshift/conformance/serial]"
  "[sig-network][Feature:MultiNetworkPolicy][Serial] should enforce a network policies on secondary network IPv4 [Suite:openshift/conformance/serial]"
  

These tests depend upon networks.operator.openshift.io resource under operator.openshift.io apigroup which is not present in MicroShift and causes error

multinetpolicy.go:193: the server could not find the requested resource (get networks.operator.openshift.io cluster)

getCluserNetwork() is looking for this resource.

---

• redirect_uris.go

  "[sig-auth][Feature:OAuthServer] OAuthClientWithRedirectURIs must validate request URIs according to oauth-client definition [Suite:openshift/conformance/parallel]"
  

  It depends upon oauthclients.oauth.openshift.io and getting invoked inside generateRedirectURIOAuthClient()

• well_known.go

  "[sig-auth][Feature:OAuthServer] well-known endpoint should be reachable [apigroup:route.openshift.io] [Suite:openshift/conformance/parallel]"
  

  It also depends upon oauth.openshift.io apigroup.

As oauth.openshift.io is not present in MicroShift, there are errors while running these tests.

-> redirect_uris.go:60: the server could not find the requested resource (post oauthclients.oauth.openshift.io)

-> well_known.go:32: the server could not find the requested resource

---

• storageclass.go

  "[sig-storage][Feature:DisableStorageClass][Serial] should not reconcile the StorageClass when StorageClassState is Unmanaged": " [Suite:openshift/conformance/serial]"
  "[sig-storage][Feature:DisableStorageClass][Serial] should reconcile the StorageClass when StorageClassState is Managed": " [Suite:openshift/conformance/serial]"
  "[sig-storage][Feature:DisableStorageClass][Serial] should remove the StorageClass when StorageClassState is Removed": " [Suite:openshift/conformance/serial]"
  

  These tests depend upon clustercsidrivers.operator.openshift.io and getting invoked inside GetSCState() function which is causing error in MicroShift due to missing operator.openshift.io apigroup.

  storageclass.go:148: the server could not find the requested resource (get clustercsidrivers.operator.openshift.io topolvm.io)
  

---

As per my understanding, all these tests somehow need oauth.openshift.io or operator.openshift.io apigroup which are not present in MicroShift. So, adding annotations can help skip them.

[ingvagabund]

/lgtm

[ingvagabund]

/approve

[chiragkyal]

/assign stlaz

[chiragkyal]

/assign bparees

[jsafrane]

/approve
storage test tag

[mfojtik]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, ingvagabund, jsafrane, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/extended/networking/OWNERS [mfojtik]
• test/extended/oauth/OWNERS [mfojtik]
• test/extended/storage/OWNERS [jsafrane,mfojtik]
• test/extended/util/annotate/generated/OWNERS [ingvagabund,jsafrane,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 716645d and 2 for PR HEAD 3f9c724 in total

[openshift-ci]

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade	3f9c724	link	false	/test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn	3f9c724	link	false	/test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d9d76e2 and 1 for PR HEAD 3f9c724 in total