Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image mirroring instructions to handle uncompressed layers #28101

Merged
merged 1 commit into from Aug 3, 2023

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jul 26, 2023

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Jul 26, 2023
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2023

@soltysh @jupierce fyi

@bparees bparees marked this pull request as ready for review July 26, 2023 21:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@jaypoulz
Copy link
Contributor

jaypoulz commented Jul 26, 2023

Looks fine to me. My only suggestion would be to consider updating annotated mirroring command to filter out the problematic image.

For a single image like this, we could suggest using grep to filter it out. Note - this is an educated guess, I haven't actually tried this:

openshift-tests images --upstream --to-repository quay.io/openshift/community-e2e-images | grep -v "e2e-27-registry-k8s-io-pause-3-9-p9APyPDU5GsW02Rk"  | oc image mirror -f - --filter-by-os=.*

This is an OK way to solve this instance, but I think longer term, we should look into seeing if we can update the openshift-tests images command to take a flag to filter out images with uncompressed layers. It may be possible to auto-detect that with some container commands, but probably the best performance is to maintain a exclude list. I'm still interested in understanding why that command output a subset of images to mirror to community-e2e-images instead of my repository, so I can look into this if you think any of these approaches are suitable.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

@bparees: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 36a0442 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-openstack-ovn 36a0442 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-upgrade 36a0442 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 36a0442 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 36a0442 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 36a0442 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor Author

bparees commented Jul 27, 2023

Looks fine to me. My only suggestion would be to consider updating annotated mirroring command to filter out the problematic image.

since i don't think it prevents the successful mirroring of the rest of the images, i'm going to leave it for now with the hope that this problem goes away at some point.

@bparees bparees added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 60b7024 and 2 for PR HEAD 36a0442 in total

@openshift-merge-robot openshift-merge-robot merged commit 4a3ca7b into openshift:master Aug 3, 2023
17 of 23 checks passed
@bparees bparees deleted the mirror branch April 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants