New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enabling multinetwork policy #28116
Remove enabling multinetwork policy #28116
Conversation
/retest-required |
/retest |
ideally speaking we don't have to do this PR since this is required only when we run this test in lanes that doesn't have multi-network policy enabled by default right? -> like its no-op in aws-serial lane, but tomorrow if we add this test to other non-aws-serial lanes, then we need to manually enable this flag via test so wondering it there is use in just leaving this as is? Or folks have to be careful to not add this test to any of the non-aws-ovn-serial lanes because those lanes don't have this feature enabled by default. |
I think the easiest thing is to remove the enabling/disabling part and leave a comment saying that this test expects the multi network policy feature to be enabled in the cluster and we don't want to enable it only for the duration of this test, since the resulting CNI rollout could cause unexpected behaviour in the tests that follow, as we've seen already. Also, waiting for the whole ovnk rollout to complete would mean stalling for ~12 minutes... twice (for ipv4, and for ipv6), if not 4 times, if we also want to wait for the rollout that enables the feature :) |
we still need the PR cause the test case tries to disable the feature as well |
31bdc4b
to
47c804d
Compare
This is now enabled by default in aws serial jobs: openshift/release#41872 Skip the test if not enabled. Signed-off-by: Tim Rozet <trozet@redhat.com>
47c804d
to
42780d1
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
wohoo tests are passing now?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@trozet: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
12c0cf7
into
openshift:master
This is now enabled by default in aws serial jobs:
openshift/release#41872