Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enabling multinetwork policy #28116

Merged

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Aug 1, 2023

This is now enabled by default in aws serial jobs:

openshift/release#41872

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@trozet
Copy link
Contributor Author

trozet commented Aug 2, 2023

/retest-required

@tssurya
Copy link
Contributor

tssurya commented Aug 2, 2023

/retest

@tssurya
Copy link
Contributor

tssurya commented Aug 2, 2023

ideally speaking we don't have to do this PR since this is required only when we run this test in lanes that doesn't have multi-network policy enabled by default right? -> like its no-op in aws-serial lane, but tomorrow if we add this test to other non-aws-serial lanes, then we need to manually enable this flag via test so wondering it there is use in just leaving this as is? Or folks have to be careful to not add this test to any of the non-aws-ovn-serial lanes because those lanes don't have this feature enabled by default.
EDIT:
if we do decide to keep this stuff we should fix the wait part for CNO

@ricky-rav
Copy link

I think the easiest thing is to remove the enabling/disabling part and leave a comment saying that this test expects the multi network policy feature to be enabled in the cluster and we don't want to enable it only for the duration of this test, since the resulting CNI rollout could cause unexpected behaviour in the tests that follow, as we've seen already. Also, waiting for the whole ovnk rollout to complete would mean stalling for ~12 minutes... twice (for ipv4, and for ipv6), if not 4 times, if we also want to wait for the rollout that enables the feature :)

@trozet
Copy link
Contributor Author

trozet commented Aug 2, 2023

ideally speaking we don't have to do this PR since this is required only when we run this test in lanes that doesn't have multi-network policy enabled by default right? -> like its no-op in aws-serial lane, but tomorrow if we add this test to other non-aws-serial lanes, then we need to manually enable this flag via test so wondering it there is use in just leaving this as is? Or folks have to be careful to not add this test to any of the non-aws-ovn-serial lanes because those lanes don't have this feature enabled by default. EDIT: if we do decide to keep this stuff we should fix the wait part for CNO

we still need the PR cause the test case tries to disable the feature as well

This is now enabled by default in aws serial jobs:

openshift/release#41872

Skip the test if not enabled.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@ricky-rav
Copy link

/retest

Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
wohoo tests are passing now?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ee9dc5 and 2 for PR HEAD 42780d1 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@trozet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 42780d1 link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 12c0cf7 into openshift:master Aug 3, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants