Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary global modification from upgrade #28143

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 7, 2023

Only the actual run test needs to set the global.

@openshift-ci openshift-ci bot requested review from bparees and spadgett August 7, 2023 14:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@neisw
Copy link
Contributor

neisw commented Aug 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: bb2fa9d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
Cluster upgrade.[sig-apps] job-upgrade
This test has passed 100.00% of 62 runs on jobs ['periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
[sig-api-machinery] Namespaces [Serial] should always delete fast (ALL of 100 namespaces in 150 seconds) [Feature:ComprehensiveNamespaceDraining] [Suite:openshift/conformance/serial] [Suite:k8s]
This test has passed 100.00% of 35 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node-serial'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Medium
[sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
This test has passed 96.88% of 32 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node'] in the last 14 days.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial bb2fa9d link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-upgrade bb2fa9d link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node bb2fa9d link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bd4bf92 into openshift:master Aug 7, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants