Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug OCPBUGS-17483: Skip invariant load balancer test for OpenStack #28154

Merged

Conversation

MaysaMacedo
Copy link
Contributor

The disruption Service tests that were previously run and skipped for OpenStack on upgrades jobs, are now run on various jobs unrelated to upgrades. This can cause the job run to fail when proxy installations are run with OpenStack given floating ip is not supported in this scenario. This commit fixes the issue by continue to skips those tests for OpenStack.

The disruption Service tests that were previously run and
skipped for OpenStack on upgrades jobs, are now run on various
jobs unrelated to upgrades. This can cause the job run to fail when
proxy installations are run with OpenStack given floating ip is not
supported in this scenario. This commit fixes the issue by continue to
skips those tests for OpenStack.
@openshift-ci openshift-ci bot requested review from bparees and mfojtik August 8, 2023 20:36
@MaysaMacedo MaysaMacedo changed the title Skip invariant load balancer test for OpenStack Bug OCPBUGS-17483: Skip invariant load balancer test for OpenStack Aug 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-17483, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The disruption Service tests that were previously run and skipped for OpenStack on upgrades jobs, are now run on various jobs unrelated to upgrades. This can cause the job run to fail when proxy installations are run with OpenStack given floating ip is not supported in this scenario. This commit fixes the issue by continue to skips those tests for OpenStack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-17483, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Aug 9, 2023

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@MaysaMacedo
Copy link
Contributor Author

Note that previously it was skipped with a different reason:
Jul 31 21:27:58.108: INFO: Skipping: [sig-network-edge] Application behind service load balancer with PDB remains available using reused connections: No historical data to calculate allowedDisruption
But in any case, we want to continue to skip it.

@MaysaMacedo
Copy link
Contributor Author

/assign @bparees

@bparees
Copy link
Contributor

bparees commented Aug 9, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 269d897 and 2 for PR HEAD a96d259 in total

@openshift-merge-robot openshift-merge-robot merged commit 380c820 into openshift:master Aug 9, 2023
18 of 22 checks passed
@openshift-ci-robot
Copy link

@MaysaMacedo: Jira Issue OCPBUGS-17483: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17483 has been moved to the MODIFIED state.

In response to this:

The disruption Service tests that were previously run and skipped for OpenStack on upgrades jobs, are now run on various jobs unrelated to upgrades. This can cause the job run to fail when proxy installations are run with OpenStack given floating ip is not supported in this scenario. This commit fixes the issue by continue to skips those tests for OpenStack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade a96d259 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial a96d259 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants