Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17477: requestheader: wait for only 3 oauth-servers to be available #28161

Merged

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Aug 10, 2023

It seems that some of the old servers might be picking new requests even though they're shutting down. This commit should either prove or disprove that theory.

Another possibility is that the authn operator is not reporting the deployment status properly, or a revision rollout is borked.

It seems that some of the old servers might be picking new
requests even though they're shutting down. This commit should
either prove or disprove that theory.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@stlaz
Copy link
Member Author

stlaz commented Aug 11, 2023

/test e2e-aws-ovn-serial
infra 😐

@stlaz
Copy link
Member Author

stlaz commented Aug 14, 2023

/test e2e-aws-ovn-serial

1 similar comment
@stlaz
Copy link
Member Author

stlaz commented Aug 15, 2023

/test e2e-aws-ovn-serial

@stlaz stlaz changed the title requestheader: wait for only 3 oauth-servers to be available OCPBUGS-17477: requestheader: wait for only 3 oauth-servers to be available Aug 15, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 15, 2023
@openshift-ci-robot
Copy link

@stlaz: This pull request references Jira Issue OCPBUGS-17477, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

It seems that some of the old servers might be picking new requests even though they're shutting down. This commit should either prove or disprove that theory.

Another possibility is that the authn operator is not reporting the deployment status properly, or a revision rollout is borked.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 15, 2023
@stlaz
Copy link
Member Author

stlaz commented Aug 15, 2023

/jira refresh

@openshift-ci-robot
Copy link

@stlaz: This pull request references Jira Issue OCPBUGS-17477, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Member Author

stlaz commented Aug 17, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2023
@openshift-ci-robot
Copy link

@stlaz: This pull request references Jira Issue OCPBUGS-17477, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ibihim ibihim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3f44c76 and 2 for PR HEAD eff3309 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial eff3309 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node eff3309 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade eff3309 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade eff3309 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-ovn eff3309 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1b8bb52 and 1 for PR HEAD eff3309 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a6a7b39 and 0 for PR HEAD eff3309 in total

@openshift-merge-robot openshift-merge-robot merged commit dae0711 into openshift:master Aug 25, 2023
17 of 22 checks passed
@openshift-ci-robot
Copy link

@stlaz: Jira Issue OCPBUGS-17477: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17477 has been moved to the MODIFIED state.

In response to this:

It seems that some of the old servers might be picking new requests even though they're shutting down. This commit should either prove or disprove that theory.

Another possibility is that the authn operator is not reporting the deployment status properly, or a revision rollout is borked.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants