Fix possibility of intervals without from/to by requiring when we Build()

[dgoodwin]

This should help anyone forgetting to call From/To and generating an
interval without.
Using Build instead of the constructor NewInterval because there are cases where we don't really know it up front.

[DennisPeriquet]

/lgtm

[openshift-trt-bot]

Job Failure Risk Analysis for sha: f4cc1d8

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-openstack-ovn	IncompleteTests Tests for this run (97) are below the historical average (1463): IncompleteTests
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (18) are below the historical average (1352): IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade	IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-csi	IncompleteTests
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd	IncompleteTests Tests for this run (18) are below the historical average (584): IncompleteTests

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a912975 and 2 for PR HEAD f4cc1d8 in total

[neisw]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9e09a48 and 2 for PR HEAD ba1cdba in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5be4722 and 1 for PR HEAD ba1cdba in total

[neisw]

/retest-required

[neisw]

Missed this earlier:

github.com/openshift/origin/pkg/monitortests/node/kubeletlogcollector
pkg/monitortests/node/kubeletlogcollector/node.go:196:4: monitorapi.NewInterval(monitorapi.SourceNetworkManagerLog, monitorapi.Warning).Locator(nodeLocator).Message(monitorapi.NewMessage().HumanMessage(message)).From undefined (type *monitorapi.IntervalBuilder has no field or method From)

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ad1f509 and 0 for PR HEAD ba1cdba in total

[openshift-ci-robot]

/hold

Revision ba1cdba was retested 3 times: holding

[openshift-trt-bot]

Job Failure Risk Analysis for sha: ba1cdba

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-sdn	IncompleteTests Tests for this run (18) are below the historical average (1307): IncompleteTests
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (18) are below the historical average (1273): IncompleteTests
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade	IncompleteTests Tests for this run (16) are below the historical average (685): IncompleteTests
pull-ci-openshift-origin-master-e2e-gcp-ovn	IncompleteTests Tests for this run (15) are below the historical average (1804): IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial	IncompleteTests Tests for this run (21) are below the historical average (607): IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-ovn-serial	IncompleteTests Tests for this run (15) are below the historical average (626): IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-ovn-fips	IncompleteTests Tests for this run (15) are below the historical average (1631): IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-csi	IncompleteTests Tests for this run (22) are below the historical average (561): IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node	Medium [sig-network] pods should successfully create sandboxes by adding pod to network This test has passed 95.65% of 23 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node'] in the last 14 days.

[neisw]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/OWNERS [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dgoodwin]

/hold cancel

[openshift-ci]

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade	9811f25	link	false	/test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn	9811f25	link	false	/test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-trt-bot]

Job Failure Risk Analysis for sha: 9811f25

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade	IncompleteTests

[deads2k]

This PR needs to be reverted. Open time intervals for start and end are perfectly valid when you consider cases of "this pod was started before the monitor began" or "this node was still ready when this monitor ended". Doing this limits useful expression from where we are today. This is why the .Clamp method exists if we wish to eliminate open endedness for rendering, but doing it here will prevent us from expressing current and valid intent.

[deads2k]

Ah, the PR doesn't do what the description says it. Do you intend to stop zero value times?