Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore stale condition challenge events #28204

Merged
merged 1 commit into from Nov 13, 2023

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Aug 19, 2023

Proposed openshift/cluster-kube-apiserver-operator#1423:

  1. Prefixes condition messages with a zero-width non-breaking space (ZWNBSP).
  2. Expects operators to quickly (within 1 min) update the condition message, removing the ZWNBSP.

Many operators emit an event when they are updating conditions (thanks to common code in libary-go) , these will trigger the pathological events tests.

This PR configured the pathological events tests to ignore these "challenge response" events.

@openshift-ci openshift-ci bot requested review from bparees and mfojtik August 19, 2023 00:57
@@ -148,6 +148,9 @@ var AllowedRepeatedEventPatterns = []*regexp.Regexp{

// Separated out in testMarketplaceStartupProbeFailure
regexp.MustCompile(MarketplaceStartupProbeFailureRegExpStr),

// stale condition challenge
regexp.MustCompile(`Requesting that the operator update this condition`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I made my code emit this event, didn't I?

We should probably stop that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you explicitly emit this event. These are reason: OperatorStatusChanged events that get emitted as usual.

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Nov 7, 2023

/retest

1 similar comment
@sanchezl
Copy link
Contributor Author

sanchezl commented Nov 7, 2023

/retest

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 5c01a91 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 5c01a91 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Nov 13, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@deads2k deads2k added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit cab1ad4 into openshift:master Nov 13, 2023
20 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202311140008.p0.gcab1ad4.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants