New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore stale condition challenge events #28204
Conversation
@@ -148,6 +148,9 @@ var AllowedRepeatedEventPatterns = []*regexp.Regexp{ | |||
|
|||
// Separated out in testMarketplaceStartupProbeFailure | |||
regexp.MustCompile(MarketplaceStartupProbeFailureRegExpStr), | |||
|
|||
// stale condition challenge | |||
regexp.MustCompile(`Requesting that the operator update this condition`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I made my code emit this event, didn't I?
We should probably stop that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you explicitly emit this event. These are reason: OperatorStatusChanged
events that get emitted as usual.
/retest |
/retest |
1 similar comment
/retest |
@sanchezl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cab1ad4
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202311140008.p0.gcab1ad4.assembly.stream for distgit openshift-enterprise-tests. |
Proposed openshift/cluster-kube-apiserver-operator#1423:
Many operators emit an event when they are updating conditions (thanks to common code in libary-go) , these will trigger the pathological events tests.
This PR configured the pathological events tests to ignore these "challenge response" events.