Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17240: etcd-recovery: fix resource leaks, more meaningful errors #28223

Merged
merged 2 commits into from
Sep 25, 2023
Merged

OCPBUGS-17240: etcd-recovery: fix resource leaks, more meaningful errors #28223

merged 2 commits into from
Sep 25, 2023

Conversation

tjungblu
Copy link
Contributor

No description provided.

@tjungblu
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

@tjungblu: The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

1 similar comment
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu tjungblu changed the title etcd-recovery: add more meaningful error messages to resource assertions etcd-recovery: add disruptive flag again, fix resource leaks, more meaningful errors Aug 28, 2023
@tjungblu
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 28, 2023
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

3 similar comments
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu tjungblu marked this pull request as draft August 29, 2023 13:15
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

1 similar comment
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

5 similar comments
@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu
Copy link
Contributor Author

/test e2e-aws-etcd-recovery

@tjungblu tjungblu marked this pull request as ready for review August 31, 2023 08:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@openshift-ci openshift-ci bot requested a review from dusk125 August 31, 2023 08:37
@deads2k
Copy link
Contributor

deads2k commented Sep 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15fb406 and 2 for PR HEAD c6995c7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ffd16ac and 1 for PR HEAD c6995c7 in total

@tjungblu
Copy link
Contributor Author

/retest-required

3 similar comments
@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@tjungblu: tjungblu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 90bcab0 and 0 for PR HEAD c6995c7 in total

@openshift-ci-robot
Copy link

/hold

Revision c6995c7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@tjungblu
Copy link
Contributor Author

/hold cancel

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 90bcab0 and 2 for PR HEAD c6995c7 in total

@tjungblu tjungblu mentioned this pull request Sep 21, 2023
Closed
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a2d29ea and 1 for PR HEAD c6995c7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e00f5fa and 0 for PR HEAD c6995c7 in total

@openshift-ci-robot
Copy link

/hold

Revision c6995c7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2023
@tjungblu
Copy link
Contributor Author

/hold cancel

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023 •
edited

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 488d528 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node c6995c7 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade c6995c7 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e00f5fa and 2 for PR HEAD c6995c7 in total

@openshift-merge-robot openshift-merge-robot merged commit 9b082a8 into openshift:master Sep 25, 2023
20 of 22 checks passed
@openshift-ci-robot
Copy link

@tjungblu: Jira Issue OCPBUGS-17240: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17240 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@dusk125 dusk125 Awaiting requested review from dusk125

@spadgett spadgett Awaiting requested review from spadgett

@geliu2016 geliu2016 Awaiting requested review from geliu2016

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tjungblu @openshift-ci-robot @deads2k @openshift-merge-robot