[release-4.12] OCPBUGS-18309: Add missing watch permission for console users

[jerolimov]

This is a manual backport of #28054

It is required to merge openshift/console-operator#789 to add a missing watch permission to users that have already get and list permission. The missing permission results in unnecessary error logs and network failures because the console UI tries automatically to watch helmchartrepositories.

This then results in performance issues customers report with the UI.

The console-operator e2e tests fails with errors like this:

[AfterEach] [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy
  github.com/openshift/origin/test/extended/util/client.go:159
STEP: Destroying namespace "e2e-test-default-rbac-policy-zb8gj" for this suite. 08/31/23 06:58:39.292
fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Aug 31 06:58:38.991: system:authenticated has extra permissions in namespace "":
{APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["watch"]}
Ginkgo exit error 1: exit with code 1

From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console-operator/789/pull-ci-openshift-console-operator-release-4.12-e2e-gcp-ovn/1697116204835016704:

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-18309, which is invalid:

• expected dependent Jira Issue OCPBUGS-16241 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual backport of #28054

It is required to merge openshift/console-operator#789 to add a missing watch permission to users that have already get and list permission. The missing permission results in unnecessary error logs and network failures because the console UI tries automatically to watch helmchartrepositories.

The console-operator e2e tests fails with errors like this:

[AfterEach] [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy
 github.com/openshift/origin/test/extended/util/client.go:159
STEP: Destroying namespace "e2e-test-default-rbac-policy-zb8gj" for this suite. 08/31/23 06:58:39.292
fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Aug 31 06:58:38.991: system:authenticated has extra permissions in namespace "":
{APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["watch"]}
Ginkgo exit error 1: exit with code 1

From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console-operator/789/pull-ci-openshift-console-operator-release-4.12-e2e-gcp-ovn/1697116204835016704:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

@bparees you have approved the 4.13 backport here #28054 (comment)

/kind bug
/cc @bparees

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-18309, which is invalid:

• expected dependent Jira Issue OCPBUGS-16241 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is a manual backport of #28054

It is required to merge openshift/console-operator#789 to add a missing watch permission to users that have already get and list permission. The missing permission results in unnecessary error logs and network failures because the console UI tries automatically to watch helmchartrepositories.

This then results in performance issues customers report with the UI.

The console-operator e2e tests fails with errors like this:

[AfterEach] [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy
 github.com/openshift/origin/test/extended/util/client.go:159
STEP: Destroying namespace "e2e-test-default-rbac-policy-zb8gj" for this suite. 08/31/23 06:58:39.292
fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Aug 31 06:58:38.991: system:authenticated has extra permissions in namespace "":
{APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["watch"]}
Ginkgo exit error 1: exit with code 1

From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console-operator/789/pull-ci-openshift-console-operator-release-4.12-e2e-gcp-ovn/1697116204835016704:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bparees]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/extended/authorization/rbac/OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerolimov]

/jira refresh

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-18309, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-16241 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-16241 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retest

[openshift-ci]

@jerolimov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade	edc4cf3	link	false	/test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jerolimov]

@bparees Required jobs passes 🥳 but this PR needs 3 more labels

Sorry, but we have no one with permission to add lgtm, backport-risk-assessed, and cherry-pick-approved. Could you apply them?

[bparees]

/lgtm

overriding cherry-pick-approved as there is no need for QE to look at this item.

[openshift-ci-robot]

@jerolimov: Jira Issue OCPBUGS-18309: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/console-operator#789 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-18309 has not been moved to the MODIFIED state.

In response to this:

This is a manual backport of #28054

It is required to merge openshift/console-operator#789 to add a missing watch permission to users that have already get and list permission. The missing permission results in unnecessary error logs and network failures because the console UI tries automatically to watch helmchartrepositories.

This then results in performance issues customers report with the UI.

The console-operator e2e tests fails with errors like this:

[AfterEach] [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy
 github.com/openshift/origin/test/extended/util/client.go:159
STEP: Destroying namespace "e2e-test-default-rbac-policy-zb8gj" for this suite. 08/31/23 06:58:39.292
fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Aug 31 06:58:38.991: system:authenticated has extra permissions in namespace "":
{APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["watch"]}
Ginkgo exit error 1: exit with code 1

From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console-operator/789/pull-ci-openshift-console-operator-release-4.12-e2e-gcp-ovn/1697116204835016704:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.