New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-19527: retry Prometheus client creation #28323
Conversation
The creation of the Prometheus client does lots of requests to the Kubernetes API behind the scene. This change adds a retry logic to avoid test failures due to transient API errors. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier: This pull request references Jira Issue OCPBUGS-19527, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
1 similar comment
/retest-required |
@simonpasquier: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws-ovn-serial |
/skip |
@bparees friendly ping :) |
Sorry for missing this, for the future please tag me directly if you're assuming i'm going to review/approve a PR, i don't look at auto/bot-assigned PRs because there are way too many and the assignment is pretty random /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@simonpasquier: Jira Issue OCPBUGS-19527: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-19527 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.15.0-0.nightly-2024-02-12-213938 |
The creation of the Prometheus client does lots of requests to the Kubernetes API behind the scene. This change adds a retry logic to avoid test failures due to transient API errors.