Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19527: retry Prometheus client creation #28323

Merged
merged 1 commit into from Nov 3, 2023

Conversation

simonpasquier
Copy link
Contributor

The creation of the Prometheus client does lots of requests to the Kubernetes API behind the scene. This change adds a retry logic to avoid test failures due to transient API errors.

The creation of the Prometheus client does lots of requests to the
Kubernetes API behind the scene. This change adds a retry logic to avoid
test failures due to transient API errors.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 12, 2023
@openshift-ci-robot
Copy link

@simonpasquier: This pull request references Jira Issue OCPBUGS-19527, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The creation of the Prometheus client does lots of requests to the Kubernetes API behind the scene. This change adds a retry logic to avoid test failures due to transient API errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 12, 2023
@simonpasquier
Copy link
Contributor Author

/retest-required

1 similar comment
@simonpasquier
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade e3ffdbe link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade e3ffdbe link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial e3ffdbe link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn e3ffdbe link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-upgrade e3ffdbe link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn e3ffdbe link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor Author

/test e2e-aws-ovn-serial

@simonpasquier
Copy link
Contributor Author

/skip

@simonpasquier
Copy link
Contributor Author

@bparees friendly ping :)

@bparees
Copy link
Contributor

bparees commented Nov 2, 2023

@bparees friendly ping :)

Sorry for missing this, for the future please tag me directly if you're assuming i'm going to review/approve a PR, i don't look at auto/bot-assigned PRs because there are way too many and the assignment is pretty random

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 138dde8 and 2 for PR HEAD e3ffdbe in total

@openshift-ci openshift-ci bot merged commit 7114b05 into openshift:master Nov 3, 2023
23 checks passed
@openshift-ci-robot
Copy link

@simonpasquier: Jira Issue OCPBUGS-19527: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-19527 has not been moved to the MODIFIED state.

In response to this:

The creation of the Prometheus client does lots of requests to the Kubernetes API behind the scene. This change adds a retry logic to avoid test failures due to transient API errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-02-12-213938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants