Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore APIServer graceful shutdown windows #28354

Merged
merged 1 commit into from Oct 26, 2023
Merged

Restore APIServer graceful shutdown windows #28354

merged 1 commit into from Oct 26, 2023

Conversation

dgoodwin
Copy link
Contributor

Discovered these were mistakenly using an incorrect source
classification, so this is changed to be apiserver specific.

Also restore them on the intervals chart and collapse into one group.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@dgoodwin
Restore APIServer graceful shutdown windows
33b948b 
Discovered these were mistakenly using an incorrect source
classification, so this is changed to be apiserver specific.

Also restore them on the intervals chart and collapse into one group.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023 •
edited

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 33b948b link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-upgrade 33b948b link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-sdn 33b948b link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 33b948b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 33b948b link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-serial 33b948b link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor Author

APIServer shutdown intervals are back: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/28354/pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade/1717208355262435328

@dgoodwin
Copy link
Contributor Author

/test e2e-gcp-ovn

@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b63f222 and 2 for PR HEAD 33b948b in total

@openshift-ci openshift-ci bot merged commit 4bf73fa into openshift:master Oct 26, 2023
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgoodwin @stbenjam @openshift-ci-robot