Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-22413: Use Centos 8 Stream mysql image in tests #28357

Merged
merged 1 commit into from Oct 31, 2023
Merged

OCPBUGS-22413: Use Centos 8 Stream mysql image in tests #28357

merged 1 commit into from Oct 31, 2023

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Oct 25, 2023 •
edited

This test frequently fails on OKD, as it is importing mysql samples from quay.io. This PR updates used images to explicitly import mysql based on CentOS 8 Stream image instead of relying on imagestreams imported by cluster-samples-operator

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 25, 2023
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-22413, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This test frequently fails on OKD, as it is importing mysql samples from quay.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Oct 25, 2023
@sdodson
Copy link
Member

sdodson commented Oct 26, 2023

Thanks, I'd encountered that as well when trying to expand OKD-SCOS tests, wasn't sure where to go.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@sdodson
Copy link
Member

sdodson commented Oct 26, 2023

/cc @soltysh

@vrutkovs
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-22413, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This test frequently fails on OKD, as it is importing mysql samples from quay.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@vrutkovs
Copy link
Member Author

OKD test are using 4.13 version for now (openshift/release#44887 would fix that)

@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

1 similar comment
@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2023
@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

2 similar comments
@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@vrutkovs
Use quay.io/sclorg/mysql-80-c8s:latest for tests
bde08d4 
This updates resources to avoid using `registry.redhat.io/rhel8/mysql-80:latest` image, as its not available on OKD. Although this image can be pulled, it is not imported in OKD imagestreams - and "Only known images" test no longer fails there
@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@vrutkovs vrutkovs changed the title OCPBUGS-22413: Add mysql image as exception for known images test WIP OCPBUGS-22413: Add mysql image as exception for known images test Oct 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2023
@vrutkovs vrutkovs changed the title WIP OCPBUGS-22413: Add mysql image as exception for known images test OCPBUGS-22413: Use Centos 8 Stream mysql image in tests Oct 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2023
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-22413, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This test frequently fails on OKD, as it is importing mysql samples from quay.io. This PR updates used images to explicitly import mysql based on CentOS 8 Stream image instead of relying on imagestreams imported by cluster-samples-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

1 similar comment
@vrutkovs
Copy link
Member Author

/test okd-e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2023

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade bde08d4 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade bde08d4 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd bde08d4 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial bde08d4 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn bde08d4 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-metal-ipi-ovn-ipv6 bde08d4 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node bde08d4 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, soltysh, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@sdodson
Copy link
Member

sdodson commented Oct 30, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@sdodson: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6bad749 and 2 for PR HEAD bde08d4 in total

@openshift-ci openshift-ci bot merged commit ae8f549 into openshift:master Oct 31, 2023
17 of 24 checks passed
@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-22413: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22413 has been moved to the MODIFIED state.

In response to this:

This test frequently fails on OKD, as it is importing mysql samples from quay.io. This PR updates used images to explicitly import mysql based on CentOS 8 Stream image instead of relying on imagestreams imported by cluster-samples-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@sdodson: new pull request created: #28365

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2023
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@sdodson sdodson

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vrutkovs @openshift-ci-robot @sdodson @openshift-cherrypick-robot @soltysh @openshift-merge-robot