Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trt-1340: backport exact and disable monitor tests options to 4.14 #28391

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Nov 9, 2023

Backport TRT-1340 Exact / Disable monitor command options for IBM-ROKS support

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 9, 2023

@neisw: This pull request references trt-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.14.z" version, but no target version was set.

In response to this:

Backport TRT-1340 Exact / Disable monitor command options for IBM-ROKS support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from csrwng and mfojtik November 9, 2023 17:35
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial e101ca1 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-etcd-recovery e101ca1 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-upgrade e101ca1 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor Author

neisw commented Nov 9, 2023

#28392 shows that GinkgoRunSuiteOptions setting DisableMonitorTests omits those tests from being started. Comparing this prs 4.14-e2e-gcp-ovn-rt-upgrade run to 28392

@jupierce
Copy link
Contributor

/approve

@jupierce jupierce added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Nov 10, 2023
@neisw
Copy link
Contributor Author

neisw commented Nov 10, 2023

/refresh-jira

@neisw
Copy link
Contributor Author

neisw commented Nov 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2023

@neisw: This pull request references trt-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.14.z" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jupierce jupierce added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 10, 2023
@neisw
Copy link
Contributor Author

neisw commented Nov 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2023

@neisw: This pull request references trt-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.14.z" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neisw
Copy link
Contributor Author

neisw commented Nov 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2023

@neisw: This pull request references trt-1340 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neisw
Copy link
Contributor Author

neisw commented Nov 10, 2023

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 10, 2023
@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 08ffa2a into openshift:release-4.14 Nov 10, 2023
20 of 23 checks passed
Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jupierce, neisw, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet