TRT-1362: Update disruption/alert test data and fix unit test #28409
Conversation
Updated synthetic tests
For whatever reason we only picked up 84 runs in the last week, which is below the required 100 to be returned. Update the key to one with over 200 per week which should be safer to rely on.
dgoodwin
force-pushed
the
manual-update-synthetic-test-data
branch
from
2399b6a
to
4092505
Compare
openshift-ci
bot
added
the
approved
dgoodwin
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@dgoodwin: This pull request references TRT-1362 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dgoodwin
changed the title
|
/jira refresh |
|
@dgoodwin: This pull request references TRT-1362 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@dgoodwin: This pull request references TRT-1362 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@dgoodwin: This pull request references TRT-1362 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label acknowledge-critical-fixes-only This has sat for weeks, and another update will trigger in two days, we need to get this in. |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/retest |
|
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit e5ca74e
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202311211133.p0.ge5ca74e.assembly.stream for distgit openshift-enterprise-tests. |
When the query last ran, it looks at just a weeks worth of data for alerts and the job key we use only had 84, below the 100 we need to be returned for testing, so the test fails. It's now over 100 if run today but just barely. Switch to a job key that has over 200, which should be more reliable.