Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Fix issue 28445 #28446

Merged
merged 1 commit into from Dec 18, 2023
Merged

NO-JIRA: Fix issue 28445 #28446

merged 1 commit into from Dec 18, 2023
+11 −11

Conversation

Rajalakshmi-Girish
Copy link
Contributor

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

Hi @Rajalakshmi-Girish. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rajalakshmi-Girish
Copy link
Contributor Author

Our job at https://prow.ppc64le-cloud.cis.ibm.net/job-history/s3/ppc64le-prow-logs/logs/postsubmit-os-origin-build-golang-master-ppc64le has been failing since 6th Dec night IST after the merge of #28436

image

@Rajalakshmi-Girish
Copy link
Contributor Author

@jwforres @mfojtik Can you please take a look?

@mfojtik
Copy link
Member

mfojtik commented Dec 8, 2023

cc @soltysh

soltysh
soltysh requested changes Dec 11, 2023
View reviewed changes
pkg/test/ginkgo/cmd_runsuite.go Outdated Show resolved Hide resolved
@Rajalakshmi-Girish
Copy link
Contributor Author

@soltysh Can you please take a look now?

soltysh
soltysh approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajalakshmi-Girish, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@soltysh soltysh changed the title Fix issue 28445 NO-JIRA: Fix issue 28445 Dec 15, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 15, 2023
@openshift-ci-robot
Copy link

@Rajalakshmi-Girish: This pull request explicitly references no jira issue.

In response to this:

Fixes #28445
The check of DryRun variable at https://github.com/openshift/origin/blob/master/pkg/test/ginkgo/cmd_runsuite.go#L235 must be done before calling clusterinfo.GetMonitorRESTConfig at https://github.com/openshift/origin/blob/master/pkg/test/ginkgo/cmd_runsuite.go#L200

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6657ea5 and 2 for PR HEAD 6f251db in total

@soltysh
Copy link
Member

soltysh commented Dec 16, 2023

/retest-required

4 similar comments
@soltysh
Copy link
Member

soltysh commented Dec 16, 2023

/retest-required

@soltysh
Copy link
Member

soltysh commented Dec 17, 2023

/retest-required

@soltysh
Copy link
Member

soltysh commented Dec 17, 2023

/retest-required

@Rajalakshmi-Girish
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023 •
edited

@Rajalakshmi-Girish: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 6f251db link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node 6f251db link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial 6f251db link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn 6f251db link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 6f251db

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-fips IncompleteTests
Tests for this run (98) are below the historical average (1494): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@soltysh
Copy link
Member

soltysh commented Dec 18, 2023

/test e2e-aws-ovn-fips

@openshift-merge-bot openshift-merge-bot bot merged commit 4bf8001 into openshift:master Dec 18, 2023
18 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202312182358.p0.g4bf8001.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@jwforres jwforres Awaiting requested review from jwforres

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openshift-tests dry-run is failing
6 participants
@Rajalakshmi-Girish @mfojtik @openshift-ci-robot @soltysh @openshift-trt-bot @openshift-bot