Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how we can add new annotations using descriptions #28461

Merged
merged 2 commits into from Dec 14, 2023

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 13, 2023

builds on #28460

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

New changes are detected. LGTM label has been removed.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 14, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2023

rebased to make PR referenceable as a guide. relabeling.

@openshift-merge-bot openshift-merge-bot bot merged commit c7b0022 into openshift:master Dec 14, 2023
18 of 22 checks passed
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 7bc418a link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 7bc418a link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202312141929.p0.gc7b0022.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants