Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to ensure all accessible-by-default apis are stable #28467

Merged
merged 2 commits into from Jan 11, 2024
Merged

add test to ensure all accessible-by-default apis are stable #28467

merged 2 commits into from Jan 11, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 15, 2023

/hold

make the exclude list prior to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Jan 9, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: b920bed

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High

deads2k
deads2k commented Jan 9, 2024
View reviewed changes
test/extended/operators/crd_must_be_stable.go
}

if len(failures) > 0 {
result.Flakef(strings.Join(failures, "\n"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it flake instead of fail.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e913a64 and 2 for PR HEAD b920bed in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52f2f6b and 1 for PR HEAD b920bed in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024 •
edited

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade b920bed link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-upgrade b920bed link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn b920bed link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-rt-upgrade b920bed link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-serial b920bed link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 663c840 and 0 for PR HEAD b920bed in total

@openshift-merge-bot openshift-merge-bot bot merged commit 64c6e3c into openshift:master Jan 11, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @openshift-trt-bot @JoelSpeed @openshift-ci-robot