Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: images: don't log entire image status on failure #28469

Merged
merged 1 commit into from Dec 21, 2023

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 15, 2023

image status contains a lot of messy superflous data, we shouldn't log it. Logging substatus and reason should be enough.

image status contains a lot of messy superflous data, we shouldn't log
it.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@DennisPeriquet
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@xueqzhan
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam stbenjam changed the title images: don't log entire image status on failure NO-JIRA: images: don't log entire image status on failure Dec 15, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 15, 2023
@openshift-ci-robot
Copy link

@stbenjam: This pull request explicitly references no jira issue.

In response to this:

image status contains a lot of messy superflous data, we shouldn't log it. Logging substatus and reason should be enough.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6657ea5 and 2 for PR HEAD dde4f43 in total

@stbenjam
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4bf8001 and 1 for PR HEAD dde4f43 in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: dde4f43

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn IncompleteTests
Tests for this run (98) are below the historical average (1601): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 14c37c2 and 0 for PR HEAD dde4f43 in total

@openshift-ci-robot
Copy link

/hold

Revision dde4f43 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@stbenjam
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 30a1d82 and 2 for PR HEAD dde4f43 in total

Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn dde4f43 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-serial dde4f43 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade dde4f43 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd dde4f43 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36eceee and 1 for PR HEAD dde4f43 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fbc3d2f and 0 for PR HEAD dde4f43 in total

@openshift-merge-bot openshift-merge-bot bot merged commit f145753 into openshift:master Dec 21, 2023
19 of 23 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202312210951.p0.gf145753.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants