Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-715: Add tests for baremetal hosts for agent installer #28477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bfournie
Copy link
Contributor

Add a new directory for agent-installer related tests with first set of tests to check baremetal hosts. The baremetal hosts tests will also check that the BMC configuration is set properly when the provisioning network is enabled.

In order to exercise this test in CI it depends on the conformance tests being added by:
openshift/release#43917
In addition, an agent test must add this env variable in order to enable the provisioning network.
AGENT_BM_HOSTS_IN_INSTALL_CONFIG=true

Add a new directory for agent-installer related tests with first
set of tests to check baremetal hosts. The baremetal hosts tests will
also check that the BMC configuration is set properly when the
provisioning network is enabled.

In order to exercise this test in CI it depends on the conformance
tests being added by:
openshift/release#43917
In addition, an agent test must add this env variable in order to
enable the provisioning network.
AGENT_BM_HOSTS_IN_INSTALL_CONFIG=true
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023

@bfournie: This pull request references AGENT-715 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Add a new directory for agent-installer related tests with first set of tests to check baremetal hosts. The baremetal hosts tests will also check that the BMC configuration is set properly when the provisioning network is enabled.

In order to exercise this test in CI it depends on the conformance tests being added by:
openshift/release#43917
In addition, an agent test must add this env variable in order to enable the provisioning network.
AGENT_BM_HOSTS_IN_INSTALL_CONFIG=true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor Author

/cc @andfasano @pawanpinjarkar @zaneb

Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bfournie
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie bfournie changed the title AGENT-715: Add tests for baremetal hosts added to agent installer AGENT-715: Add tests for baremetal hosts for agent installer Dec 19, 2023
@bfournie
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 629b00a link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 629b00a link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 629b00a link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-ovn-ipv6 629b00a link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 629b00a

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (424) are below the historical average (2017): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants