Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27341: pkg/monitortests/clusterversionoperator: Add an exception for ingress going Available=False on IngressUnavailable #28480

Merged

Conversation

wking
Copy link
Member

@wking wking commented Dec 20, 2023

It would be great if the ingress operator addressed this issue, but:

  • We do not want to block pull requests from landing, or releases from being accepted, until they adjust their operator. This behavior is likely longstanding, and we want to give folks time to gradually tighten operator logic without needing to rush.
  • Even once the ingress folks adjust their operator, this test suite will be used for test-cases that touch older releases (e.g. update and rollback jobs), and the test case doesn't yet allow for distinctions like "the ingress operator at the time of the Available=False condition predates the bugfix landing, so that should still fall under the earlier exception".

… going Available=False on IngressUnavailable

It would be great if the ingress operator addressed this
issue, but:

* We do not want to block pull requests from landing, or releases from
  being accepted, until they adjust their operator.  This behavior is
  likely longstanding, and we want to give folks time to gradually
  tighten operator logic without needing to rush.
* Even once the ingress folks adjust their operator, this test
  suite will be used for test-cases that touch older releases
  (e.g. update and rollback jobs), and the test case doesn't yet allow
  for distinctions like "the ingress operator at the time of the
  Available=False condition predates the bugfix landing, so that
  should still fall under the earlier exception".
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd bdb42ba link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-csi bdb42ba link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-serial bdb42ba link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade bdb42ba link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn bdb42ba link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@derekhiggins
Copy link
Contributor

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm

Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

@derekhiggins: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/df722430-a988-11ee-96e7-bba34a5c86e8-0

@derekhiggins
Copy link
Contributor

/payload-job periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-sdn-bm-upgrade

Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

@derekhiggins: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-sdn-bm-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1af3c0e0-a989-11ee-9784-d83eeca2c876-0

@derekhiggins
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@dgoodwin
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, dgoodwin, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@derekhiggins
Copy link
Contributor

/retitle OCPBUGS-27341: pkg/monitortests/clusterversionoperator: Add an exception for ingress going Available=False on IngressUnavailable

@openshift-ci openshift-ci bot changed the title pkg/monitortests/clusterversionoperator: Add an exception for ingress going Available=False on IngressUnavailable OCPBUGS-27341: pkg/monitortests/clusterversionoperator: Add an exception for ingress going Available=False on IngressUnavailable Jan 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 18, 2024
@openshift-ci-robot
Copy link

@wking: This pull request references Jira Issue OCPBUGS-27341, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

It would be great if the ingress operator addressed this issue, but:

  • We do not want to block pull requests from landing, or releases from being accepted, until they adjust their operator. This behavior is likely longstanding, and we want to give folks time to gradually tighten operator logic without needing to rush.
  • Even once the ingress folks adjust their operator, this test suite will be used for test-cases that touch older releases (e.g. update and rollback jobs), and the test case doesn't yet allow for distinctions like "the ingress operator at the time of the Available=False condition predates the bugfix landing, so that should still fall under the earlier exception".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@derekhiggins
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@derekhiggins: This pull request references Jira Issue OCPBUGS-27341, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@derekhiggins
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 18, 2024
@openshift-ci-robot
Copy link

@derekhiggins: This pull request references Jira Issue OCPBUGS-27341, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan January 18, 2024 12:23
@openshift-merge-bot openshift-merge-bot bot merged commit 5d7702e into openshift:master Jan 18, 2024
17 of 22 checks passed
@openshift-ci-robot
Copy link

@wking: Jira Issue OCPBUGS-27341: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27341 has been moved to the MODIFIED state.

In response to this:

It would be great if the ingress operator addressed this issue, but:

  • We do not want to block pull requests from landing, or releases from being accepted, until they adjust their operator. This behavior is likely longstanding, and we want to give folks time to gradually tighten operator logic without needing to rush.
  • Even once the ingress folks adjust their operator, this test suite will be used for test-cases that touch older releases (e.g. update and rollback jobs), and the test case doesn't yet allow for distinctions like "the ingress operator at the time of the Available=False condition predates the bugfix landing, so that should still fall under the earlier exception".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@derekhiggins
Copy link
Contributor

/cherry-pick release-4.15

@derekhiggins
Copy link
Contributor

/cherrypick release-4.15

@openshift-cherrypick-robot

@derekhiggins: new pull request created: #28531

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-21-092529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants