Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certs again #28489

Merged
merged 3 commits into from Jan 4, 2024
Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 3, 2024

starting the new year right. Skips hypershift because their certs don't align well. It needs addressing eventually, but will bring us closer to being enforceable.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2024

/retest

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: efc9644

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-openstack-ovn High
[sig-apps] ReplicaSet should serve a basic image on each replica with a public image [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
This test has passed 99.93% of 1525 runs on release 4.16 [Overall] in the last week.
---
[sig-api-machinery] AdmissionWebhook [Privileged:ClusterAdmin] should mutate custom resource with pruning [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
This test has passed 100.00% of 3 runs on release 4.16 [amd64 ha openstack ovn] in the last week.
---
[sig-cli] Kubectl client Simple pod should support exec [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 100.00% of 3 runs on release 4.16 [amd64 ha openstack ovn] in the last week.
---
[sig-node] Containers should use the image defaults if command and args are blank [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
This test has passed 100.00% of 2 runs on release 4.16 [amd64 ha openstack ovn] in the last week.
---
Showing 4 of 15 test results

@vrutkovs
Copy link
Member

vrutkovs commented Jan 4, 2024

/test e2e-aws-ovn-kubevirt

@deads2k deads2k added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 4, 2024
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

for hypershift tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node efc9644 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade efc9644 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn efc9644 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member

vrutkovs commented Jan 4, 2024

/hold cancel

No flaking TLS tests in that kubevirt job

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 13c8e24 into openshift:master Jan 4, 2024
20 of 23 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202401041812.p0.g13c8e24.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants