OCPBUGS-26025: Do not apply master label to make sure SNO jobs pass

[harche]

The logic behind the TestOpenshiftNodeLabeling test was to pick up a worker node and apply the labels that the worker nodes is not allowed to have. While on a normal cluster the test worked fine, it started failing on the SNO clusters. This is because, on the SNO clusters the only available node is labelled with both worker and master labels. This would make this test pick up the (only available) node and apply the master label. However, since a node in SNO cluster already has master label, kubelet will fail that operation during the validation.

Since the original intention of the test is to just apply labels that aren't allowed for the given node. IMO, even if we drop the master label from the test, it will still hold good as a test for forbidden labels.

[openshift-ci-robot]

@harche: This pull request references Jira Issue OCPBUGS-26025, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The logic behind the TestOpenshiftNodeLabeling test was to pick up a worker node and apply the labels that the worker nodes is not allowed to have. While on a normal cluster the test worked fine, it started failing on the SNO clusters. This is because, on the SNO clusters the only available node is labelled with both worker and master labels. This would make this test pick up the (only available) node and apply the master label. However, since a node in SNO cluster already has master label, kubelet will fail that operation during the validation.

Since the original intention of the test is to just apply labels that aren't allowed for the given node. IMO, even if we drop the master label from the test, it will still hold good as a test for forbidden labels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[harche]

/jira refresh

[harche]

/jira refresh

[openshift-ci-robot]

@harche: This pull request references Jira Issue OCPBUGS-26025, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@harche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-csi	d632c25	link	false	/test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-upgrade	d632c25	link	false	/test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn	d632c25	link	false	/test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial	d632c25	link	false	/test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[deads2k]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, harche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ad7a60d and 2 for PR HEAD d632c25 in total

[openshift-ci-robot]

@harche: Jira Issue OCPBUGS-26025: All pull requests linked via external trackers have merged:

• openshift/origin#28499

Jira Issue OCPBUGS-26025 has been moved to the MODIFIED state.

In response to this:

The logic behind the TestOpenshiftNodeLabeling test was to pick up a worker node and apply the labels that the worker nodes is not allowed to have. While on a normal cluster the test worked fine, it started failing on the SNO clusters. This is because, on the SNO clusters the only available node is labelled with both worker and master labels. This would make this test pick up the (only available) node and apply the master label. However, since a node in SNO cluster already has master label, kubelet will fail that operation during the validation.

Since the original intention of the test is to just apply labels that aren't allowed for the given node. IMO, even if we drop the master label from the test, it will still hold good as a test for forbidden labels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-01-14-231715