Refine explanation of meeting regenerate after expiry requirement #28502
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| To assert that a particular cert/key pair or CA bundle can do this, add the annotation to the secret or configmap. | ||
| ```yaml | ||
| annotations: | ||
| certificates.openshift.io/auto-regenerate-after-offline-expiry: https//github.com/link/to/pr/adding/annotation, "quote escaped formatted name of e2e test that ensures the PKI artifact functions properly" |
There was a problem hiding this comment.
I think just the test name should be sufficient, we can find out which PR added it with git blame (also across releases)
There was a problem hiding this comment.
I think just the test name should be sufficient, we can find out which PR added it with
git blame(also across releases)
Based on past experience in kube with api approvals, there's nothing quite like the link embedded.
| QE has required test every release that ensures the functionality works every release. | ||
| Links should be provided in the PR adding the annotation. | ||
| If you have not done this, you should not merge the annotation. |
There was a problem hiding this comment.
| If you have not done this, you should not merge the annotation. | |
| If you have not done this, you should not merge the PR setting this annotation. |
There was a problem hiding this comment.
@vrutkovs based on William's comment, I'm going to merge this to help us communicate where we're at with a perma-link.
I'm completely fine adding this extra verbiage, but I need to merge with green verifies.
|
The clarifications included in this PR for the generated document about how to meet the requirement provide the information PMs and Eng teams need to better understand what they need to do. |
|
merging to allow linking for email/jira/etc. |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202401052011.p0.g544cbb0.assembly.stream for distgit openshift-enterprise-tests. |
/assign @vrutkovs @sanchezl