Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-26206: Update cluster-monitoring-operator request limits #28506

Merged

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Jan 5, 2024

From the new autodl data in bigquery:

SELECT
  APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(50)] AS Median,
  APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(95)] AS Percentile_95,
  APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(99)] AS Percentile_99
FROM
  openshift-ci-data-analysis.ci_data_autodl_test.operator_watch_requests
WHERE
  JobRunName LIKE '%4.15%aws%'

Set to 110% of the P99.

From the new autodl data in bigquery:

```
SELECT
  APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(50)] AS Median,
  APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(95)] AS Percentile_95,
  APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(99)] AS Percentile_99
FROM
  openshift-ci-data-analysis.ci_data_autodl_test.operator_watch_requests
WHERE
  JobRunName LIKE '%4.15%aws%'
```

Set to 110% of the P99.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 5, 2024
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-26206, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26069 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-26069 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

From the new autodl data in bigquery:

SELECT
 APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(50)] AS Median,
 APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(95)] AS Percentile_95,
 APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(99)] AS Percentile_99
FROM
 openshift-ci-data-analysis.ci_data_autodl_test.operator_watch_requests
WHERE
 JobRunName LIKE '%4.15%aws%'

Set to 110% of the P99.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and mfojtik January 5, 2024 19:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@DennisPeriquet
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
Copy link
Contributor

openshift-ci bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

stbenjam commented Jan 5, 2024

/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jan 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ecca9c7 and 2 for PR HEAD e952ecb in total

Copy link
Contributor

openshift-ci bot commented Jan 5, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade e952ecb link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial e952ecb link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-etcd-recovery e952ecb link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c036b4d into openshift:release-4.15 Jan 5, 2024
20 of 23 checks passed
@openshift-ci-robot
Copy link

@stbenjam: Jira Issue OCPBUGS-26206: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26206 has been moved to the MODIFIED state.

In response to this:

From the new autodl data in bigquery:

SELECT
 APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(50)] AS Median,
 APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(95)] AS Percentile_95,
 APPROX_QUANTILES(WatchRequestCount, 100)[OFFSET(99)] AS Percentile_99
FROM
 openshift-ci-data-analysis.ci_data_autodl_test.operator_watch_requests
WHERE
 JobRunName LIKE '%4.15%aws%'

Set to 110% of the P99.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202401060052.p0.gc036b4d.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet