OCPBUGS-27210: Restore HTTP/2 tests in test/extended/router

[frobware]

Restoring HTTP/2 Tests with Enhanced Client Configuration

Context

This PR reintroduces the HTTP/2 tests previously removed by PR #28522. The key difference now is the modified client code and the updated test expectations, which enable these tests to pass successfully.

Changes

• The makeHTTPClient function in test/extended/router/http2.go has been refined to better handle HTTP/2 and HTTP/1.1 protocols during TLS handshake.
• We have reintroduced the http2-default-cert-edge and http2-default-cert-reencrypt tests, which were removed due to previous limitations.
• The test expectations have been adjusted to align with the new client configuration, ensuring that these tests now pass under the updated protocol handling.

Impact

The reintroduction of these tests, with the enhanced client setup, significantly improves our ability to accurately test and assert the behaviour of HTTP/2 in the router, particularly under various certificate configurations.

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-27210, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Restoring HTTP/2 Tests with Enhanced Client Configuration

Context

This PR reintroduces the HTTP/2 tests previously removed by PR #28522. The key difference now is the modified client code and the updated test expectations, which enable these tests to pass successfully.

Changes

• The makeHTTPClient function in test/extended/router/http2.go has been refined to better handle HTTP/2 and HTTP/1.1 protocols during TLS handshake.
• We have reintroduced the http2-default-cert-edge and http2-default-cert-reencrypt tests, which were removed due to previous limitations.
• The test expectations have been adjusted to align with the new client configuration, ensuring that these tests now pass under the updated protocol handling.

Impact

The reintroduction of these tests, with the enhanced client setup, significantly improves our ability to accurately test and assert the behaviour of HTTP/2 in the router, particularly under various certificate configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[frobware]

/jira refresh

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-27210, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/extended/router/OWNERS [frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

Thanks!
/approve
/lgtm

[openshift-ci-robot]

@frobware: Jira Issue OCPBUGS-27210: All pull requests linked via external trackers have merged:

• openshift/origin#28540

Jira Issue OCPBUGS-27210 has been moved to the MODIFIED state.

In response to this:

Restoring HTTP/2 Tests with Enhanced Client Configuration

Context

This PR reintroduces the HTTP/2 tests previously removed by PR #28522. The key difference now is the modified client code and the updated test expectations, which enable these tests to pass successfully.

Changes

• The makeHTTPClient function in test/extended/router/http2.go has been refined to better handle HTTP/2 and HTTP/1.1 protocols during TLS handshake.
• We have reintroduced the http2-default-cert-edge and http2-default-cert-reencrypt tests, which were removed due to previous limitations.
• The test expectations have been adjusted to align with the new client configuration, ensuring that these tests now pass under the updated protocol handling.

Impact

The reintroduction of these tests, with the enhanced client setup, significantly improves our ability to accurately test and assert the behaviour of HTTP/2 in the router, particularly under various certificate configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@frobware: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-serial	b9fac64	link	false	/test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-rt-upgrade	b9fac64	link	false	/test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-01-24-031529