Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23115: Test builds with subscription content #28560

Merged

Conversation

adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Jan 26, 2024

Add end to end tests to verify we can build images that install
RHEL subscription content via yum/dnf install. These tests
need a fully subscribed cluster to function properly - for example,
a ROSA cluster. If the cluster is not subscribed/does not have its
SCA certificates synced via the Insights Operator, the tests are
skipped.

The test verifies the instructions in the official OpenShift
documentation, which includes copying the entitlement keys to
the build's namespace. Docs are currently being drafted in openshift/openshift-docs#70897

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@adambkaplan
Copy link
Contributor Author

@bparees @deads2k who owns the contributor experience for openshift/origin these days?

I'm running into a thorny Ginkgo issue - at 7bc0f7f, my new specs register and get pulled into the openshift/build suite.

But once I start implementing actual logic (current branch state), the specs disappear and don't show up in any test suite. The fundamental structure of my test doesn't seem to have changed - what broke here?

@adambkaplan adambkaplan changed the title WIP - Test builds with subscription content OCPBUGS-23115: Test builds with subscription content Jan 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 27, 2024
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Jira Issue OCPBUGS-23115, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding e2e tests that verify we can build images with subscription content if the cluster is subscribed and the Insights operator has synced the cluster's simple content access keys.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Add end to end tests to verify we can build images that install
RHEL subscription content via `yum/dnf install`. These tests
need a fully subscribed cluster to function properly - for example,
a ROSA cluster. If the cluster is not subscribed/does not have its
SCA certificates synced via the Insights Operator, the tests are
skipped.

The test verifies the instructions in the official OpenShift
documentation [1], which includes copying the entitlement keys to
the build's namespace.

[1] https://docs.openshift.com/container-platform/4.14/cicd/builds/running-entitled-builds.html
@adambkaplan
Copy link
Contributor Author

A follow up pull request should verify the procedure for using entitlements via the shared resource CSI driver.

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn 6aabb36 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node 6aabb36 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-openstack-ovn 6aabb36 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 6aabb36 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 6aabb36 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 30, 2024
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Jira Issue OCPBUGS-23115, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 30, 2024
@adambkaplan
Copy link
Contributor Author

@bparees
Copy link
Contributor

bparees commented Jan 30, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@ayushsatyam146
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, ayushsatyam146, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4e368eb and 2 for PR HEAD 6aabb36 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 461b731 into openshift:master Feb 1, 2024
18 of 23 checks passed
@openshift-ci-robot
Copy link

@adambkaplan: Jira Issue OCPBUGS-23115: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23115 has been moved to the MODIFIED state.

In response to this:

Add end to end tests to verify we can build images that install
RHEL subscription content via yum/dnf install. These tests
need a fully subscribed cluster to function properly - for example,
a ROSA cluster. If the cluster is not subscribed/does not have its
SCA certificates synced via the Insights Operator, the tests are
skipped.

The test verifies the instructions in the official OpenShift
documentation, which includes copying the entitlement keys to
the build's namespace. Docs are currently being drafted in openshift/openshift-docs#70897

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202402011241.p0.g461b731.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-02-002725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants