Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1494: Add monitortest for cloud function on azure #28582

Merged

Conversation

DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Feb 8, 2024

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.
  • Ensure metal sdn test does not have disruption (this test should be skipped on metal)
  • Confirm 3 non-metal jobs have 0s disruption on aws-network-liveness

The new resource group is called do-not-delete-trt-liveness at portal.azure.com.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@DennisPeriquet: This pull request references TRT-1493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@DennisPeriquet
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024
//externalServiceURL = "https://us-east4-openshift-gce-devel.cloudfunctions.net/openshift-tests-endpoint"

// Load balancer URL
externalServiceURL = "http://52.168.131.231/health"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the IP of the LB in my personal Azure account

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been changed to use a LB in the Openshift azure account

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@DennisPeriquet: This pull request references TRT-1493 which is a valid jira issue.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@DennisPeriquet: This pull request references TRT-1493 which is a valid jira issue.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.

The new resource group is called do-not-delete-trt-liveness at portal.azure.com.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DennisPeriquet
Copy link
Contributor Author

/hold

Until problems in https://issues.redhat.com/browse/TRT-1522 are resolved, this PR is not to merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2024
@DennisPeriquet
Copy link
Contributor Author

/hold

Until problems in https://issues.redhat.com/browse/TRT-1522 are resolved, this PR is not to merge.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@DennisPeriquet: This pull request references TRT-1493 which is a valid jira issue.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.
  • Ensure metal sdn test does not have disruption (or we can avoid running this on metal)

The new resource group is called do-not-delete-trt-liveness at portal.azure.com.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@DennisPeriquet DennisPeriquet force-pushed the trt-1493-azure-liveness branch 2 times, most recently from 95ff9b9 to 316b1ee Compare February 26, 2024 20:08
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2024

@DennisPeriquet: This pull request references TRT-1493 which is a valid jira issue.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.
  • Ensure metal sdn test does not have disruption (this test should be skipped on metal)
  • Confirm 3 non-metal jobs have 0s disruption on aws-network-liveness

The new resource group is called do-not-delete-trt-liveness at portal.azure.com.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2024

@DennisPeriquet: This pull request references TRT-1493 which is a valid jira issue.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.
  • Ensure metal sdn test does not have disruption (this test should be skipped on metal)
  • Confirm 3 non-metal jobs have 0s disruption on aws-network-liveness

The new resource group is called do-not-delete-trt-liveness at portal.azure.com.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DennisPeriquet
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@dgoodwin
Copy link
Contributor

/lgtm

With A29y on this wouldn't be anything I'd consider critical, however you are watcher next week so feel free to label if you'd like it to go in.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 433afaa

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Low
[sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator
This test has passed 35.00% of 60 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

@DennisPeriquet DennisPeriquet changed the title TRT-1493: Add monitortest for cloud function on azure TRT-1494: Add monitortest for cloud function on azure Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@DennisPeriquet: This pull request references TRT-1494 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Hit an endpoint (on a VM behind a load-balancer in azure) to test azure connectivity during test runs in a way that (attempts to) mimic pods in an Openshift cluster. This way we can compare disruption problems noted in TRT-1466.

This is just a test using an LB/VM in a personal Azure account.

TODO:

  • Move the endpoint to an LB/VM on an Openshift owned Azure account.
  • Ensure metal sdn test does not have disruption (this test should be skipped on metal)
  • Confirm 3 non-metal jobs have 0s disruption on aws-network-liveness

The new resource group is called do-not-delete-trt-liveness at portal.azure.com.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@DennisPeriquet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 4169e1e link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial 4169e1e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 4169e1e link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 4169e1e link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 4169e1e

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Low
[sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator
This test has passed 34.55% of 55 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

@neisw
Copy link
Contributor

neisw commented Mar 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DennisPeriquet,dgoodwin,neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d6231f and 2 for PR HEAD 4169e1e in total

@openshift-merge-bot openshift-merge-bot bot merged commit 3515349 into openshift:master Mar 27, 2024
18 of 22 checks passed
@DennisPeriquet DennisPeriquet deleted the trt-1493-azure-liveness branch March 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants