Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1522: Revert #28594 "TRT-1476: Re-introduce the GCP liveness endpoint test" #28603

Merged
merged 1 commit into from Feb 19, 2024
Merged

TRT-1522: Revert #28594 "TRT-1476: Re-introduce the GCP liveness endpoint test" #28603

merged 1 commit into from Feb 19, 2024

Conversation

DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Feb 19, 2024 •
edited by openshift-ci bot

Reverts #28594 ; tracked by TRT-1522

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

[https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/4.16.0-0.nightly-2024-02-19-165214](https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/4.16.0-0.nightly-2024-02-19-165214\) failed and I am trying a revert to see if the test passes

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job something-metal

CC: @DennisPeriquet

PR created by Revertomatic™️

@DennisPeriquet
Revert "Merge pull request openshift#28594 from DennisPeriquet/TRT-14…
aa6bce0 
…99-revert-revert"

This reverts commit bd2ae41, reversing
changes made to 7812f3c.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024 •
edited by openshift-ci bot

@DennisPeriquet: This pull request references TRT-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #28594 ; tracked by TRT-1522

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

[https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/4.16.0-0.nightly-2024-02-19-165214](https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/4.16.0-0.nightly-2024-02-19-165214\) failed and I am trying a revert to see if the test passes

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job something-metal

CC: @DennisPeriquet

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@DennisPeriquet
Copy link
Contributor Author

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-aws-ovn-cgroupsv2

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@DennisPeriquet: Overrode contexts on behalf of DennisPeriquet: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-aws-ovn-cgroupsv2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@neisw
Copy link
Contributor

neisw commented Feb 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c9f3ff into openshift:master Feb 19, 2024
22 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@DennisPeriquet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202402200039.p0.g2c9f3ff.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@DennisPeriquet DennisPeriquet deleted the revert-28594-1708381020968 branch February 21, 2024 13:47
@dgoodwin dgoodwin mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@neisw neisw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DennisPeriquet @openshift-ci-robot @neisw @openshift-bot