Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trt-1530: specify deployment id for unique log names #28613

Merged
merged 2 commits into from Feb 26, 2024
Merged

trt-1530: specify deployment id for unique log names #28613

merged 2 commits into from Feb 26, 2024

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Feb 24, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2024 •
edited by openshift-ci bot

@neisw: This pull request references trt-1530 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@neisw
Copy link
Contributor Author

neisw commented Feb 24, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e601d90-d31a-11ee-8dab-e2d6ebb0a48f-0

@neisw neisw force-pushed the trt-1530-pod-network-service-alt branch from c8ab604 to 3ce5d5b Compare February 24, 2024 17:42
@neisw
Copy link
Contributor Author

neisw commented Feb 24, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/401b2d20-d33e-11ee-89f4-59dccfc56a7a-0

@neisw
Copy link
Contributor Author

neisw commented Feb 25, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f962e500-d3ea-11ee-9c37-eca126ea537b-0

@neisw
Copy link
Contributor Author

neisw commented Feb 25, 2024

/payload-abort

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2024

@neisw: aborted active payload jobs for pull request #28613

@neisw
Copy link
Contributor Author

neisw commented Feb 25, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ee3b260-d3eb-11ee-8a5b-3baf7fbe0536-0

@neisw
Copy link
Contributor Author

neisw commented Feb 25, 2024

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/openshift-origin-28613-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade/1761762293827244032/artifacts/e2e-gcp-ovn-rt-upgrade/openshift-e2e-test/artifacts/junit/e2e-monitor-tests__20240225-165813.xml

Initializing output file to /var/log/persistent-logs/disruption-pod-to-service-network-5eed6720-8f79-496c-878f-d0b1ebd666ee.jsonl

@neisw
Copy link
Contributor Author

neisw commented Feb 26, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6b060990-d43f-11ee-8601-7398204ad0e7-0

deads2k
deads2k reviewed Feb 26, 2024
View reviewed changes
pkg/cmd/openshift-tests/disruption/poll-service/poll_service_options.go Outdated
//print starting content to the log so that we can simply scrape the log to find all entries at the end
o.OriginalOutFile.Write(startingContent)
// print starting content to the log so that we can simply scrape the log to find all entries at the end
o.OriginalOutFile.Write([]byte(fmt.Sprintf("Found existing content: %s", string(startingContent))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
o.OriginalOutFile.Write([]byte(fmt.Sprintf("Found existing content: %s", string(startingContent))))
o.OriginalOutFile.Write([]byte(fmt.Sprintf("Found existing content:\n %s", string(startingContent))))

@deads2k
Copy link
Contributor

deads2k commented Feb 26, 2024

one change, then lgtm

@neisw neisw force-pushed the trt-1530-pod-network-service-alt branch from 0c9b436 to 6e81ef1 Compare February 26, 2024 19:05
@neisw neisw marked this pull request as ready for review February 26, 2024 20:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@deads2k
Copy link
Contributor

deads2k commented Feb 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor Author

neisw commented Feb 26, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6634d60-d4e5-11ee-8bcc-ef70b6e42c72-0

@openshift-merge-bot openshift-merge-bot bot merged commit 019ccef into openshift:master Feb 26, 2024
18 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202402270439.p0.g019ccef.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@neisw neisw mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@csrwng csrwng Awaiting requested review from csrwng

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neisw @openshift-ci-robot @deads2k @openshift-bot