Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRKLDS-1076: oc idle: Check idling annotation in services not endpoints #28619

Merged
merged 1 commit into from Mar 15, 2024
Merged

WRKLDS-1076: oc idle: Check idling annotation in services not endpoints #28619

merged 1 commit into from Mar 15, 2024

Conversation

ardaguclu
Copy link
Member

We have started fully relying on service's annotation instead of endpoints in oc idle.

This PR is prerequisite of openshift/oc#1692

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2024 •
edited by openshift-ci bot

@ardaguclu: This pull request references WRKLDS-1076 which is a valid jira issue.

In response to this:

We have started fully relying on service's annotation instead of endpoints in oc idle.

This PR is prerequisite of openshift/oc#1692

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2024
@ardaguclu ardaguclu mentioned this pull request Feb 27, 2024
Merged
@ardaguclu
Copy link
Member Author

/cc @soltysh

@openshift-ci openshift-ci bot requested a review from soltysh February 27, 2024 07:00
@ardaguclu ardaguclu changed the title WRKLDS-1076: oc idle: Check correct annotation in services not endpoints WRKLDS-1076: oc idle: Check idling annotation in services not endpoints Feb 27, 2024
@ardaguclu
Copy link
Member Author

/hold
some failures are real

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024 •
edited

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn 49f515b link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node 49f515b link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-rt-upgrade 49f515b link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-ovn 49f515b link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-cgroupsv2 49f515b link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-upgrade 49f515b link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@soltysh
Copy link
Member

soltysh commented Mar 15, 2024

This will simplify tests
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 15, 2024
@soltysh
Copy link
Member

soltysh commented Mar 15, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 0de0977 into openshift:master Mar 15, 2024
16 of 22 checks passed
@ardaguclu ardaguclu deleted the wrklds-1076 branch March 15, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@soltysh soltysh

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ardaguclu @openshift-ci-robot @soltysh