OCPBUGS-29614: update skipUnlessMachineAPIOperator function #28625
Conversation
This change updates the check for the machine api operator to inspect the number of machines that might be returned. If zero machines are returned it indicates that the cluster has the CRD but contains no instances, in these cases we want to skip the test.
openshift-ci-robot
added
the
jira/valid-reference
|
@elmiko: This pull request references Jira Issue OCPBUGS-29614, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
cc @JoelSpeed ptal |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@elmiko: This pull request references Jira Issue OCPBUGS-29614, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
What is the impact of this on the have machine resources [apigroup:machine.openshift.io] test. Why is that test successfully skipped in UPI but not the CPMS test?
@elmiko can you run a pre merge payload job test on the specific cases that we had the bug reported against, I'd like to see the output from these two tests specifically
|
/pj-rehearse help |
|
/payload help |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi |
|
@elmiko: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1c8c7550-d657-11ee-9894-c889fffe55dd-0 |
|
@JoelSpeed it seems like there were no logs created from that run, or am i missing something? |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi |
|
@elmiko: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4533f100-d7d2-11ee-8b6e-1dacea8a49be-0 |
|
in the latest test run i can see that the test we want is being skipped, but we might also be skipping other tests from the suite. |
|
@JoelSpeed i think we need to understand more about how these tests are run because now i see it skipping several tests:
|
|
rethinking a little, perhaps this is what we want to be seeing on a upi cluster? |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-serial i want to see if this runs properly on an ipi install |
|
@elmiko: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f1f2d10-d810-11ee-98c2-958a47dcb860-0 |
|
it looks like the tests did run on that cluster, i think this fix is working like we want. @stbenjam could you confirm? |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
it seems like the test failures are part of the teardown, the actual test run looked fine. i think we should merge this. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@stbenjam looking at the test outputs, it seems like the CPMS tests are being run in the proper places and are being skipped in upi configurations. the current failures seem unrelated. |
|
It doesn't look like the AWS UPI job got to the point of running the tests, was there another one I missed? /test e2e-aws-ovn-upi |
i saw one yesterday that was skipping appropriately, let me see if i can find it |
|
oops, wrong pr, that's your's lol |
|
i know i saw the skip message i put into this PR in one of the upi test runs, i thought it was the one you manually triggered but i can't find it now. also, it seems like there is some other problem preventing that from running properly now. /test e2e-aws-ovn-upi |
|
Looks good now |
|
/hold Revision a9ab8be was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
i think we might need to manually override some of the tests /retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-gcp-ovn-upgrade Unrelated failure. |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: a9ab8be
|
1 similar comment
|
Job Failure Risk Analysis for sha: a9ab8be
|
|
/override ci/prow/e2e-gcp-ovn Unrelated |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@elmiko: Jira Issue OCPBUGS-29614: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-29614 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403111814.p0.g3bf7a4a.assembly.stream.el8 for distgit openshift-enterprise-tests. |
This change updates the check for the machine api operator to inspect the number of machines that might be returned. If zero machines are returned it indicates that the cluster has the CRD but contains no instances, in these cases we want to skip the test.