TRT-1567: Revert #28589 "AUTH-483: Add a monitor test to check the existence of required-scc annotation in platform workloads" #28659
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@DennisPeriquet: This pull request references TRT-1567 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
@DennisPeriquet: This pull request references TRT-1567 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold I'm leaning toward this PR not being at fault. But still not sure why the aggregator is calling this test a failure. |
openshift-ci
bot
added
the
do-not-merge/hold
|
i see this in the aggregated job summary: I think what's happening is that particular test passes only in 1 job but does not appear as passing in any other job; I checked 4 of the jobs and didn't see it in flaking or passing and that's probably what's causing the failure. So now I wonder why is this test not running for all jobs? and if it is supposed to run for all jobs, then this revert makes sense. |
|
/hold cancel This needs to be reverted, dynamic names of namespaces should NOT be in test names. So, it's causing payloads to fail and blowing up our table of known test names since each one is unique since it contains a namespace. The must-gather failures like this: are happening when the test is unlucky enough to be running at the same time the must-gather pods exist. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DennisPeriquet, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-ovn-serial |
|
@DennisPeriquet: Overrode contexts on behalf of DennisPeriquet: ci/prow/e2e-aws-ovn-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit 2cecd5f
into
openshift:master
|
@DennisPeriquet: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403180813.p0.g2cecd5f.assembly.stream.el8 for distgit openshift-enterprise-tests. |
Reverts #28589 ; tracked by TRT-1567
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
4.16.0-0.ci-2024-03-16-025152 is the first payload where this test failed the payload
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:
CC: @liouk
ps. I noticed on https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-aws-ovn-upgrade-4.16-minor-release-openshift-release-analysis-aggregator/1768832918135771136 that although the aggregation points to https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade/1768832917330464768 as a failed job, the job passes. So now, I'm wondering if this is an aggregation problem and not a test problem. I see in your original PR that this should flake.