TRT-1545: Complete removal of non-structured locator/message use #28663
Conversation
But by no means all, hundreds remain.
openshift-ci
bot
added
the
approved
|
/retest |
|
Job Failure Risk Analysis for sha: 932a700
|
|
/hold cancel Large followups coming after shiftweek. |
|
/hold Wrong PR, this is the large followup. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel This has nothing to do with known images used by tests. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-gcp-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest |
|
/retest This is getting ridiculous. |
|
/override ci/prow/e2e-aws-ovn-fips |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-gcp-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Job Failure Risk Analysis for sha: f075c64
|
This was previously looking for namespaces starting with e2e-, my change flipped it to a contains, which then picked up openshift-e2e-loki, which does use a external image that we do not want this test failing on. Restored to a prefix check.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DennisPeriquet, dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Job Failure Risk Analysis for sha: 4037ee7
|
1 similar comment
|
Job Failure Risk Analysis for sha: 4037ee7
|
|
/override ci/prow/e2e-aws-ovn-fips Missing a node, this job has passed before, cannot hit the magic combo to get this PR through. |
|
/hold cancel |
|
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-fips In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Job Failure Risk Analysis for sha: 4037ee7
|
|
/override ci/prow/e2e-gcp-ovn-upgrade |
|
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-gcp-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit eb64483
into
openshift:master
Builds on #28597 by removing remaining locator and message read/writes not related to serialization.
If successful, next step will be to remove the flat string legacy locator/message, reclaim those fields for the structured fields, collapse Condition into Interval.