Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1625: Revert #28741 "OCPBUGS-32923: Fix allowed firing alerts not triggering" #28747

Merged

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Apr 26, 2024

Reverts #28741 ; tracked by TRT-1625

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Something appears to have broken with alerts, not sure what's going on yet but lets get it out.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Unclear

CC: @dgoodwin

PR created by Revertomatic™️

…alerts"

This reverts commit d015548, reversing
changes made to 59ab90c.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@dgoodwin: This pull request references TRT-1625 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #28741 ; tracked by TRT-1625

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Something appears to have broken with alerts, not sure what's going on yet but lets get it out.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Unclear

CC: @dgoodwin

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@dgoodwin: This pull request references TRT-1625 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #28741 ; tracked by TRT-1625

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Something appears to have broken with alerts, not sure what's going on yet but lets get it out.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Unclear

CC: @dgoodwin

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn

@xueqzhan
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-builds, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b04fe1a into openshift:master Apr 26, 2024
23 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants