Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-1809: Provide SCC access via RBAC #28771

Merged
merged 2 commits into from
May 8, 2024
Merged

API-1809: Provide SCC access via RBAC #28771

merged 2 commits into from
May 8, 2024

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented May 6, 2024

/assign @cblecker

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024 •
edited by openshift-ci bot

@soltysh: This pull request references API-1809 which is a valid jira issue.

In response to this:

/assign @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2024
@cblecker
Copy link
Member

cblecker commented May 6, 2024

/lgtm
🚀

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@cblecker
Copy link
Member

cblecker commented May 6, 2024

/assign @deads2k

@deads2k
Copy link
Contributor

deads2k commented May 6, 2024

violations appears to be an uncaught doc update required. The verify script must be busted.

@vrutkovs

@deads2k
Copy link
Contributor

deads2k commented May 6, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@deads2k
Copy link
Contributor

deads2k commented May 6, 2024

perhaps #28772 fixes it

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15c3521 and 2 for PR HEAD cba4d28 in total

@cblecker
Copy link
Member

cblecker commented May 6, 2024

/retest-required

@vrutkovs vrutkovs mentioned this pull request May 7, 2024
Merged
@vrutkovs
Copy link
Member

vrutkovs commented May 7, 2024

/test e2e-gcp-ovn-builds

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 75f7e06 and 1 for PR HEAD cba4d28 in total

@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files and removed lgtm Indicates that a PR is ready to be merged. labels May 7, 2024
@cblecker
Copy link
Member

cblecker commented May 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 0afa314 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node 0afa314 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-rt-upgrade 0afa314 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 0afa314 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 574269c into openshift:master May 8, 2024
19 of 23 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202405080039.p0.g574269c.assembly.stream.el9 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@soltysh soltysh deleted the api_1809 branch May 8, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cblecker cblecker

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@soltysh @openshift-ci-robot @cblecker @deads2k @vrutkovs @openshift-bot