Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1656: Revert #28750 "OCPBUGS-33041: Add RoleBinding for BuildConfig Webhooks" #28781

Merged
merged 1 commit into from May 8, 2024
Merged

TRT-1656: Revert #28750 "OCPBUGS-33041: Add RoleBinding for BuildConfig Webhooks" #28781

merged 1 commit into from May 8, 2024

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented May 8, 2024 •
edited

Reverts #28750 ; tracked by TRT-1656

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

TestWebhook test is failing on minor upgrades due to a problem with AUTH-509, until that's resolved we need to kick this out of the payload. It can be reintroduced when /payload testing verifies minor upgrades succeed

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.16 nightly blocking

CC: @adambkaplan

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#28750 from adambkaplan/unauthent…
e3c844d 
…icated-webhook-bc"

This reverts commit 75f7e06, reversing
changes made to 15c3521.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #28750 ; tracked by TRT-1656

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

TestWebhook test is failing on minor upgrades due to a problem with AUTH-509, until that's resolved we need to kick this out of the payload. It can be reintroduced when /payload testing verifies minor upgrades succeed

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.16 nightly blocking should succeed

CC: @adambkaplan

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #28750 ; tracked by TRT-1656

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

TestWebhook test is failing on minor upgrades due to a problem with AUTH-509, until that's resolved we need to kick this out of the payload. It can be reintroduced when /payload testing verifies minor upgrades succeed

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.16 nightly blocking should succeed

CC: @adambkaplan

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

stbenjam commented May 8, 2024

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/skip

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #28750 ; tracked by TRT-1656

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

TestWebhook test is failing on minor upgrades due to a problem with AUTH-509, until that's resolved we need to kick this out of the payload. It can be reintroduced when /payload testing verifies minor upgrades succeed

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.16 nightly blocking

CC: @adambkaplan

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor

dgoodwin commented May 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan
Copy link
Contributor

adambkaplan commented May 8, 2024 •
edited

/hold

This will break OpenShift controller manager PRs

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2024
@stbenjam
Copy link
Member Author

stbenjam commented May 8, 2024

/hold cancel

Please don't hold this; OpenShift policy is if you break payloads, you get reverted, even at the expense of broken presubmits.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2024
@stbenjam
Copy link
Member Author

stbenjam commented May 8, 2024

/skip
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi

In response to this:

/skip
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented May 8, 2024

/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn-edge-zones

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-builds, ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn-edge-zones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented May 8, 2024

/override ci/prow/e2e-gcp-ovn-builds

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn-builds

In response to this:

/override ci/prow/e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented May 8, 2024

/skip
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade

@adambkaplan adambkaplan mentioned this pull request May 8, 2024
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade

In response to this:

/skip
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k merged commit c5782f9 into openshift:master May 8, 2024
23 of 24 checks passed
@stbenjam stbenjam deleted the revert-28750-1715182080664 branch May 8, 2024 20:28
@stbenjam stbenjam restored the revert-28750-1715182080664 branch May 8, 2024 20:28
@stbenjam stbenjam deleted the revert-28750-1715182080664 branch May 8, 2024 20:28
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones e3c844d link unknown /test e2e-aws-ovn-edge-zones
ci/prow/e2e-metal-ipi-ovn-ipv6 e3c844d link unknown /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-fips e3c844d link unknown /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn-builds e3c844d link unknown /test e2e-gcp-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stbenjam @openshift-ci-robot @dgoodwin @adambkaplan @deads2k