Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 10841: Default --ignore-not-found to true for delete --all #3619

Merged
merged 1 commit into from
Jul 8, 2015
Merged

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jul 7, 2015

Fixes #3602
Upstream PR at kubernetes/kubernetes#10841

@liggitt
Copy link
Contributor Author

liggitt commented Jul 7, 2015

@deads2k PTAL

@deads2k
Copy link
Contributor

deads2k commented Jul 7, 2015

I guess an upstream lgtm is good enough to take this as a patch. If the upstream patch ends up rejected, you need to pull this back out.

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2675/) (Image: devenv-fedora_1947)

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@liggitt
Copy link
Contributor Author

liggitt commented Jul 7, 2015

@ncdc hub flake, I think:

--- FAIL: TestImage (0.91s)
    client_test.go:105: unexpected error: error getting X-Docker-Token from openshift/origin-not-found: Get http://index.docker.io/v1/repositories/openshift/origin-not-found/images/: EOF

Re[merge]

@liggitt
Copy link
Contributor Author

liggitt commented Jul 7, 2015

@csrwng is this indicative of a hub error?

error: no image or template matched "mysql"
!!! Error in hack/test-cmd.sh:501
  '[ "$(oc new-app mysql --name=db | grep db)" ]' exited with status 1
Call stack:
  1: hack/test-cmd.sh:501 main(...)
Exiting with status 1

Re[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3554/)

@liggitt
Copy link
Contributor Author

liggitt commented Jul 8, 2015

--- FAIL: TestRunAll (2.03s)
    newapp_test.go:686: emptyDir volumes: Error mismatch! Expected <nil>, got no image or template matched "mysql": the image "ee2cb077006e3385648619d6adf66d5ac53cfb11c4b2708636c5be0a12b23ff7" in repository "library/mysql" was not found and may have been deleted

Re[merge]

Will spawn an issue to separate tests with external dependencies to a separate suite

@liggitt
Copy link
Contributor Author

liggitt commented Jul 8, 2015

grrrrr

/data/src/github.com/openshift/origin/assets/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:113
  var template = new Error(this.message);

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 65acb16

openshift-bot pushed a commit that referenced this pull request Jul 8, 2015
@openshift-bot openshift-bot merged commit 574e35e into openshift:master Jul 8, 2015
@csrwng
Copy link
Contributor

csrwng commented Jul 8, 2015

@liggitt yup, it looks like we have a good number of external dependencies, including git repos, docker hub images, etc.

@liggitt liggitt deleted the delete_all branch July 13, 2015 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants