Add persistent storage jenkins template #4221
Conversation
|
@mnagy ptal as our resident persistent storage expert. |
bparees
force-pushed
the
jenkins_persistent
branch
from
8472309
to
c56e799
Compare
| "volumeMounts": [ | ||
| { | ||
| "name": "${JENKINS_SERVICE_NAME}-data", | ||
| "mountPath": "/var/lib/jenkins" |
There was a problem hiding this comment.
Make sure this dir is not used for other things like configuration. In db images we use the pattern /var/lib/{pgsql,mysql,mongodb}/data
There was a problem hiding this comment.
you mean make sure content doesn't already exist in that dir in the image before mounting?
There was a problem hiding this comment.
yes, if /var/lib/jenkins contains other files (binaries, config, etc) this mount will override the files.
There was a problem hiding this comment.
Apparently the Dockerfile doesn't put anything there explicitly, just don't know about yum.
There was a problem hiding this comment.
yeah it does not, this is working ok in the ephemeral template (which uses an emptydir for this same volume/mount path)
|
@bparees maybe update |
|
good idea, will update the readme. |
bparees
force-pushed
the
jenkins_persistent
branch
from
c56e799
to
206181e
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3021/) (Image: devenv-fedora_2173) |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4240/) |
|
@bparees just a note, maybe you forgot committing changes to the README if you made them. |
|
@rhcarvalho ? readme changes are showing up for me. |
bparees
force-pushed
the
jenkins_persistent
branch
from
206181e
to
6566d14
Compare
|
forgot to add file to examples_test. [merge] |
|
Evaluated for origin test up to 6566d14 |
|
@bparees it wasn't showing for me, but now it does. |
|
Evaluated for origin merge up to 6566d14 |
Merged by openshift-bot
No description provided.