bump(github.com/fsouza/go-dockerclient) c68e3a80d465c178e452c843ccd9928570893203 #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bparees ptal |
|
@csrwng is this with sync of what we have in source-to-image repo? |
|
@mfojtik, no... will create a pull there as well. Thx for reminding me |
|
might need to wait on this... @ncdc has exec changes in flight that might need to go in concurrent with this |
|
also, did we ever resolve the version compatibility issues? will this version work against older dockers? |
|
yes, it checks the version of server API |
|
we need to stay in sync with upstream on the go-dockerclient used... so this needs to be paired with a PR there, but you may want to check with @ncdc first. this version will break |
|
cool, @ncdc I'll leave it up to you to do the proper updates after your changes go in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fix for BZ 1255502